Declaration of Drush\Sql\Sqlsqlsrv::creds() should be compatible with Drush\Sql\SqlBase::creds()

[kenorb]

$ drush sql-connect
Declaration of Drush\Sql\Sqlsqlsrv::creds() should be compatible with Drush\Sql\SqlBase::creds($hide_password = true)           [warning]
Sqlsqlsrv.php:5
$ php --version
PHP 7.2.0beta1 (cli) 

[greg-1-anderson]

The most important question here is what version of Drush are you using, is it site-local or global Drush, are you running the launcher, etc.

Just tried HEAD of master with a site-local Drush, and it worked fine. From the symptoms, looks like you are mixing versions of Drush.

[kenorb]

It's the PHP 7.x warning about function declaration being not compatible.

So basically:

public function creds()

in SqlSqlsrv.php

should be compatible with:

public function creds($hide_password = true)

defined in SqlBase.php.

See:

$ grep n\ creds\( *
SqlBase.php:    public function creds($hide_password = true)
SqlMysql.php:    public function creds($hide_password = true)
SqlOracle.php:    public function creds()
SqlPgsql.php:    public function creds($hide_password = true)
SqlSqlite.php:    public function creds($hide_password = true)
SqlSqlsrv.php:    public function creds()

---

Reproducible steps on empty folder (ideally use PHP 7.1, as 7.2 could have more errors, e.g. prefix with DRUSH_PHP=php71):

1. Install clean Drupal: drush -y qd --no-server
2. Go to Drupal root: cd quick-drupal-*/drupal
3. Change db driver to sqlsrv, e.g. by: ex +'%s/sqlite/sqlsrv/g|wq!' sites/default/settings.php
4. Run drush sql-connect.

You should see the warning in PHP 7.x. Same issue with oracle driver.

---

$ drush --version
 Drush Version   :  8.1-dev 

[greg-1-anderson]

Oh, I see. I read the error message too quickly and missed that you were using one of the uncommon database types. Those were community-submitted, and are not heavily tested by Drush maintainers. PRs to fix this are welcome.

[weitzman]

merged. thanks.