Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runserver should be able to serve https #3102

Closed
candrews opened this issue Oct 25, 2017 · 4 comments
Closed

runserver should be able to serve https #3102

candrews opened this issue Oct 25, 2017 · 4 comments

Comments

@candrews
Copy link

With the increasing use of https, it would be very helpful if drush runserver could start an https server instead of a plain http server is an option indicating as such is provided.

I suggest that an --https option be added to the already documented options (https://drushcommands.com/drush-8x/runserver/runserver/).

This change would allow for improved testing (such as if the project requires https for some functionality being tested, ex HTML5 Geolocation).

Originally discovered by acquia/blt#2188

@greg-1-anderson
Copy link
Member

drush runserver is a wrapper around the php built-in webserver, which only supports http connections. In order to provide this functionality, we would need to bundle (or worse, implement) an https-capable web server. This is out of scope for Drush. If you need https for testing, you should install an https-capable web server for the purpose. Circle 2.0 and Travis allow testing with docker containers; this would probably be the best way to go for this particular use case.

@candrews
Copy link
Author

Instead of directly using PHP's built in web server, could you consider using https://github.com/mpyw/php-hyper-builtin-server instead? That supports all that PHP's built in supports but also HTTPS.

@greg-1-anderson
Copy link
Member

I think it's out of scope for Drush to bundle a webserver. @weitzman can reopen if he disagrees.

A better workaround would be for test suites that need https to install a separate webserver.

@weitzman
Copy link
Member

I agree. We have had runserver for many years and this is the first feature request for https. Folks are solving this elsewhere, as Greg suggests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants