Tokens Studio support 🎉 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ed7c6bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const tokenSet = path[0]; | ||
| if (typeof v.value === 'string') { | ||
| if (v.value.trim().startsWith('{') && !v.value.trim().startsWith(`{${tokenSet}`)) { | ||
| v.value = v.value.trim().replace('{', `{${tokenSet}.`); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
| for (const [property, propertyValue] of Object.entries(v.value)) { | ||
| if (typeof propertyValue !== 'string') continue; | ||
| if (propertyValue.trim().startsWith('{') && !propertyValue.trim().startsWith(`{${tokenSet}`)) { | ||
| v.value[property] = v.value[property].trim().replace('{', `{${tokenSet}.`); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
Deploying with
|
| Latest commit: |
ed7c6bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b4e1e3b9.cobalt-ui.pages.dev |
| Branch Preview URL: | https://tokens-studio.cobalt-ui.pages.dev |
drwpow
force-pushed
the
tokens-studio
branch
6 times, most recently
from
13904df
to
d2a4e68
Compare
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds Tokens Studio support! 🥳
This is a better solution than a 50%-completed Figma sync functionality that I haven’t finished after over a year of procrastinating. Hopefully this is a win–win scenario:
Mini-FAQ
Is this project partnering with Tokens Studio?
No; this project is completely unaffiliated with Tokens Studio.
Isn’t Tokens Studio paid?
The 100% free version of the plugin offers everything Cobalt supports and then some. This is the only reason this solution is being proposed.
The paid “Pro” version offers some extra features not everyone needs (which are beyond the current scope of the W3C Design Tokens spec anyway). If, in the future, a necessary feature to make Figma syncing work is gated behind a paywall, this project may explore other options. But for now this is a great solution.
I was using
co sync! Can you keep it around for longer?If you were using this, I’d actually love for you to comment & explain how you managed manually typing hundreds of tokens in a
tokens.config.jsfile in a sane way. Not to shame, of course—I’d actually love to hear your workflow to provide better workarounds. But also to inform the next steps of Figma syncing.Why not release a Tokens Studio transformer instead?
Tokens Studio has a Style Dictionary transformer they officially support. I initially looked into doing something similar, but realized that’s a one-off and not pluggable.
Tokens Studio is meant to be a “no-code” solution, and at the moment that’s completely different than Cobalt’s approach of a pluggable, adaptable, configurable dev tool for the W3C Design Tokens format. The simplest solution for Tokens Studio support seemed to be adding support on Cobalt’s end to just parse the format automatically, which turned out to be trivial (it’s basically just converting
typeto$typeand a tiny bit of math for basic support).If, in the future, Tokens Studio releases more transformers, including one for the W3C Design Tokens format, I’d be happy to collaborate / align better on what they’re doing.