-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$ref in parameters not being transpiled #984
Comments
I retried with the code from #986 and it did not fix this problem |
Reposted from #989 I think that the problem could be in this part of the code https://github.com/drwpow/openapi-typescript/blob/main/src/transform/operation-object.ts#L72-L74 This is expecting Originally posted by @axelhzf in #989 (comment) |
@wolfy1339 yeah this is one area where it assumes there’s a hint in the In the meantime, please see the generated types here: https://github.com/drwpow/openapi-typescript/pull/997/files#diff-b43503415e823d5023ec484469dd542b2e2d6698bcc6112e4225053b9bab6dc7R83. Is this output acceptable as a workaround? |
I believe that would work. |
Until openapi-ts/openapi-typescript#984 is fixed (and any other blocking issue that may be found afterwards)
Until openapi-ts/openapi-typescript#984 is fixed (and any other blocking issue that may be found afterwards)
Description
A brief description of the bug.
ReferenceObjects are not being transpiled into the types from the schema when used in OperationObject for the parameters field
This was working fine in 5.x, it stopped working in the 6.x releases.
openapi-typescript
6.0.3
18.12.0
macOS 13, Windows 11, etc.
Reproduction
How can this be reproduced / when did the error occur?
https://raw.githubusercontent.com/octokit/octokit-next.js/main/cache/types-openapi/ghes-3.2.json on line 431, for the
/admin/hooks/{hook_id}
pathGenerated types: https://raw.githubusercontent.com/octokit/octokit-next.js/fix-types/packages/types-openapi-ghes-3.2/index.d.ts on line 17291
You can see that only the first parameter gets transpiled
Expected result
(in case it’s not obvious)
Checklist
The text was updated successfully, but these errors were encountered: