fix(openapi-fetch): treat default response as error #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6851afa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
force-pushed
the
openapi-fetch-default-response
branch
from
9299c95 to
e5d7dca
Compare
Deploying with
|
| Latest commit: |
6851afa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c5d0a551.openapi-ts.pages.dev |
| Branch Preview URL: | https://openapi-fetch-default-respon.openapi-ts.pages.dev |
drwpow
force-pushed
the
openapi-fetch-default-response
branch
from
e5d7dca to
6851afa
Compare
Deploying with
|
| Latest commit: |
6851afa
|
| Status: | ⚡️ Build in progress... |
vdawg-git
pushed a commit
to vdawg-git/openapi-typescript
that referenced
this pull request
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
response.defaultwas simply ignored. Instead, treat it as an error.While some may disagree—technically it can be either—in my observation this is how most people use it since its purpose is handling unexpected HTTP codes (aka exceptions aka errors).
At any rate, interpreting
defaultas something rather than ignoring it is an improvement.How to Review
Tests added; CI should pass
Checklist
examples/directory updated (only applicable for openapi-typescript)