Fix .d.ts resolution-mode #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3d3d0f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
force-pushed
the
fix-dts-types
branch
from
7679908 to
ef5d0e0
Compare
Deploying with
|
| Latest commit: |
3d3d0f6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ba132744.openapi-ts.pages.dev |
| Branch Preview URL: | https://fix-dts-types.openapi-ts.pages.dev |
drwpow
force-pushed
the
fix-dts-types
branch
2 times, most recently
from
8c8b298 to
cf17b01
Compare
drwpow
force-pushed
the
fix-dts-types
branch
from
cf17b01 to
d98696e
Compare
drwpow
force-pushed
the
fix-dts-types
branch
from
db64098 to
3d3d0f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1306 by restoring original
resolution-mode. When"moduleResolution": "NodeNext"was added (using ESM in Node), that changed the generated types:This undoes that change to just remove
resolution-modealtogether and restore previous behavior.How to Review
This is actually completely opaque to CI and Git because it’s in the generated files. But the check is just seeing that
resolution-modeis gone from all.d.tsfiles:CI should pass (it should still build)
Checklist
N/A