Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explode query params by default #1399

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Explode query params by default #1399

merged 1 commit into from
Oct 20, 2023

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Oct 20, 2023

Changes

Fixes #1331. Introduces a ⚠️ Breaking Change that changes the default behavior of querySerializer to explode query params by default (which now follows the expected behavior from the OpenAPI specification; it didn’t before).

How to Review

  • Tests were added to track behavior

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2023

🦋 Changeset detected

Latest commit: c130807

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-fetch Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 20, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c130807
Status: ✅  Deploy successful!
Preview URL: https://866ff439.openapi-ts.pages.dev
Branch Preview URL: https://query-params.openapi-ts.pages.dev

View logs

@drwpow drwpow merged commit 4fca1e4 into main Oct 20, 2023
7 checks passed
@drwpow drwpow deleted the query-params branch October 20, 2023 00:15
@github-actions github-actions bot mentioned this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection query parameter placeholders are replaced by comma separated list instead of multiple parameters
1 participant