Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior for empty arrays and objects in default querySerializer #1404

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Oct 23, 2023

Changes

Fixes #1403 by skipping empty arrays and objects in querySerializer

How to Review

  • Tests added

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023

🦋 Changeset detected

Latest commit: 6c5ad30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-fetch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 23, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6c5ad30
Status: ✅  Deploy successful!
Preview URL: https://5d027e8f.openapi-ts.pages.dev
Branch Preview URL: https://fix-query-serializer.openapi-ts.pages.dev

View logs

@drwpow drwpow merged commit 93204e4 into main Oct 23, 2023
8 checks passed
@drwpow drwpow deleted the fix-query-serializer branch October 23, 2023 04:45
@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defaultQuerySerializer does not handle empty array correctly
1 participant