Skip to content

Consider removing .uwrap from things that cannot be really unwraped #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue Jul 7, 2020 · 1 comment
Closed

Consider removing .uwrap from things that cannot be really unwraped #452

sobolevn opened this issue Jul 7, 2020 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@sobolevn
Copy link
Member

sobolevn commented Jul 7, 2020

We have a problem in our design: some classes do raise UnwrapFailedError when .unwrap() is called. And some not.

For example, ReaderResult will always return a function on .unwrap.
This is incosistent and even ugly.

I guess we should only allow unwrap on types that do raise.
@sobolevn sobolevn added bug Something isn't working enhancement New feature or request labels Jul 7, 2020
@sobolevn
Copy link
Member Author

Done, see #446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sobolevn