Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up child processes when exiting for any reason #39

Open
ds300 opened this issue Apr 15, 2023 · 6 comments
Open

Clean up child processes when exiting for any reason #39

ds300 opened this issue Apr 15, 2023 · 6 comments
Labels
good first issue Good for newcomers

Comments

@ds300
Copy link
Owner

ds300 commented Apr 15, 2023

We can probably copy what yarn 2 does here: https://github.com/yarnpkg/berry/blob/cb2eecc859145235dcab6e338b264069c64ba027/packages/yarnpkg-shell/sources/pipe.ts#L28

i.e. keep a reference to any spawned process and make sure they get cleaned up on sigterm and whatever else

@ds300 ds300 converted this from a draft issue Apr 15, 2023
@ds300 ds300 added the good first issue Good for newcomers label Apr 15, 2023
@Yuvraj102
Copy link

hello @ds300, I'm interested in solving this issue, Please assign it to me.

@ds300 ds300 self-assigned this Apr 16, 2023
@ds300
Copy link
Owner Author

ds300 commented Apr 16, 2023

All yours!

@ds300 ds300 assigned Yuvraj102 and unassigned ds300 Apr 16, 2023
@ds300 ds300 moved this from 🔖 Ready to 🏗 In progress in lazyrepo road to beta Apr 16, 2023
@ds300
Copy link
Owner Author

ds300 commented Apr 30, 2023

@Yuvraj102 I'm assuming work has stalled on your side, so let me know if you still want to do this, otherwise I'll open it up to other folks soon. Thanks 👍

@Yuvraj102
Copy link

Hello @ds300, I'm looking into it, Havent made any commits yet, But I'm still interested in this, Will definitely reach out with some questions soon
Thanks

@Yuvraj102
Copy link

I'll definitely try to close this within a week, Apologies for the delay.

@ds300
Copy link
Owner Author

ds300 commented Apr 30, 2023

All good, no rush! I appreciate the help :)

@Yuvraj102 Yuvraj102 removed their assignment May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants