-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up child processes when exiting for any reason #39
Comments
hello @ds300, I'm interested in solving this issue, Please assign it to me. |
All yours! |
@Yuvraj102 I'm assuming work has stalled on your side, so let me know if you still want to do this, otherwise I'll open it up to other folks soon. Thanks 👍 |
Hello @ds300, I'm looking into it, Havent made any commits yet, But I'm still interested in this, Will definitely reach out with some questions soon |
I'll definitely try to close this within a week, Apologies for the delay. |
All good, no rush! I appreciate the help :) |
We can probably copy what yarn 2 does here: https://github.com/yarnpkg/berry/blob/cb2eecc859145235dcab6e338b264069c64ba027/packages/yarnpkg-shell/sources/pipe.ts#L28
i.e. keep a reference to any spawned process and make sure they get cleaned up on sigterm and whatever else
The text was updated successfully, but these errors were encountered: