Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always include lockfile in cache key #58

Open
ds300 opened this issue Apr 19, 2023 · 0 comments
Open

Always include lockfile in cache key #58

ds300 opened this issue Apr 19, 2023 · 0 comments

Comments

@ds300
Copy link
Owner

ds300 commented Apr 19, 2023

The user's lockfile should always be included in every cache key, unless we start doing static analysis of tasks to find out which packages they use like a big boy build system (Let's not do that 😓)

We can add an unsafe option to the CacheConfig type to turn off this behaviour on a per-script basis, maybe unsafe_excludeLockfile

Note that the lockfile path can be configured in yarn. Doesn't look like that's the case with npm/pnpm.

@ds300 ds300 converted this from a draft issue Apr 19, 2023
@ds300 ds300 moved this from 📋 Backlog to 🔖 Ready in lazyrepo road to beta Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant