Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't process folders #53

Closed
2 tasks done
mwermelinger opened this issue Feb 11, 2024 · 0 comments
Closed
2 tasks done

Can't process folders #53

mwermelinger opened this issue Feb 11, 2024 · 0 comments
Assignees
Labels
effort: medium These issues require some work priority: high type: error Bug in the code, typo or omission in the docs, etc.

Comments

@mwermelinger
Copy link
Member

mwermelinger commented Feb 11, 2024

An error in the handling of paths in check_folder() means that folders can't be processed anymore:

  • version 1.2 on PyPI crashes when calling endswith(".py") on a Path object
  • version 1.2.1 reports 'file not found' because open() gets the basename, not full name.

To do:

  • do str(path) instead of path.name
  • adds tests that process a folder, not just an individual sample file
@mwermelinger mwermelinger added type: error Bug in the code, typo or omission in the docs, etc. priority: high effort: medium These issues require some work labels Feb 11, 2024
@mwermelinger mwermelinger self-assigned this Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium These issues require some work priority: high type: error Bug in the code, typo or omission in the docs, etc.
Projects
None yet
Development

No branches or pull requests

1 participant