Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't require Python 3.10 #73

Closed
2 of 3 tasks
mwermelinger opened this issue Sep 10, 2024 · 0 comments · Fixed by #74
Closed
2 of 3 tasks

don't require Python 3.10 #73

mwermelinger opened this issue Sep 10, 2024 · 0 comments · Fixed by #74
Labels
effort: medium These issues require some work priority: high type: error Bug in the code, typo or omission in the docs, etc.

Comments

@mwermelinger
Copy link
Member

mwermelinger commented Sep 10, 2024

A tutor found that allowed crashes on the briefing notebook in a new M269 24J installation in Raspberry Pi. More generally, it crashes with option -m when pytype is installed but Python 3.10 isn't. To recreate on macOS,

  1. do PATH=/usr/bin:/bin so that the Python binary links in /usr/local/bin aren't found
  2. do m269-24j to activate the M269 environment and change to the M269 folder
  3. do allowed -m book-r1/python/m269_test.py

To fix this, need probably to revert to old check of whether allowed is being run under Python 3.10 or 3.11. The comment in PR #57 seems to indicate I hardwired 3.10 to make it work with old pytype versions.

  • change allowed.py
  • re-run all tests
  • make new 1.5.1 release
@mwermelinger mwermelinger added type: error Bug in the code, typo or omission in the docs, etc. priority: high effort: medium These issues require some work labels Sep 10, 2024
@mwermelinger mwermelinger linked a pull request Sep 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium These issues require some work priority: high type: error Bug in the code, typo or omission in the docs, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant