Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented new Test-SqlDscIsRole for testing whether a server principal is a Role. Fixed documentation in Test-SqlDscIsLogin #2060

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implemented new Test-SqlDscIsRole for testing whether a server principal is a Role. Fixed documentation in Test-SqlDscIsLogin #2060

wants to merge 2 commits into from
+151 −3

Conversation

IAMJDA
Copy link

@IAMJDA IAMJDA commented Feb 23, 2025 •
edited by johlju
Loading

Pull Request (PR) description

Added a public command that returns whether the server role exists

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@IAMJDA IAMJDA requested review from johlju and a team as code owners February 23, 2025 16:13
Jens Damm added 2 commits February 23, 2025 17:06
@codecov Codecov
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94%. Comparing base (85ea1ed) to head (dfebdb3).

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #2060   +/-   ##
====================================
  Coverage    94%     94%           
====================================
  Files        94      95    +1     
  Lines      7930    7930           
====================================
+ Hits       7500    7504    +4     
+ Misses      430     426    -4
Flag Coverage Δ
unit 94% <100%> (+<1%) ⬆️
Files with missing lines Coverage Δ
source/Public/Test-SqlDscIsLogin.ps1 100% <ø> (ø)
source/Public/Test-SqlDscIsRole.ps1 100% <100%> (ø)

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlju johlju Awaiting requested review from johlju johlju is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test-SqlDscIsRole: New command proposal
1 participant
@IAMJDA