Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test-SqlDscIsRole: New command proposal #2058

Open
johlju opened this issue Feb 22, 2025 · 1 comment · May be fixed by #2060
Open

Test-SqlDscIsRole: New command proposal #2058

johlju opened this issue Feb 22, 2025 · 1 comment · May be fixed by #2060
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community.

Comments

@johlju
Copy link
Member

johlju commented Feb 22, 2025

Command proposal

Suggest adding a public command that returns whether the server role exist.

Proposed parameters

Parameter Mandatory Data type Description Default value Allowed values
ServerObject Yes [Microsoft.SqlServer.Management.Smo.Server] Specifies current server connection object. None None
Name Yes [System.String] Specifies the name of the server role. None None

Special considerations or limitations

This can be similar to Test-SqlDscIsLogin. Should return [System.Boolean] and ServerObject should use ValueFromPipeline. This command should have unit tests added as well.
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Feb 22, 2025
This was referenced Feb 22, 2025
Open
Open
@IAMJDA IAMJDA linked a pull request Feb 23, 2025 that will close this issue
Open
9 tasks
@IAMJDA
Copy link

IAMJDA commented Feb 23, 2025

I opened a PR for that one. Also fixed the documentation for Test-SqlDscIsLogin 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Milestone
No milestone
2 participants
@johlju @IAMJDA