Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set-SqlDscServerPermission: Not possible to set server permissions for a server role #2059

Open
johlju opened this issue Feb 22, 2025 · 1 comment · May be fixed by #2061
Open

Set-SqlDscServerPermission: Not possible to set server permissions for a server role #2059

johlju opened this issue Feb 22, 2025 · 1 comment · May be fixed by #2061
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community.

Comments

@johlju
Copy link
Member

johlju commented Feb 22, 2025

Problem description

Update Set-SqlDscServerPermission to be able to set permission on server roles.

Verbose logs

Try to set permission on a server role and the command will return that it is not a login. Verbose log is not available. See parent issue.

How to reproduce

Try to set a permission on a server role.

Expected behavior

Should be able to set permission on a server role.

Current behavior

Fails to set permission on a server role.

Suggested solution

Use the proposed command in issue #2058 together with Test-SqlDscIsLogin to verify that the passed name is either server role or server login.

Operating system the target node is running

n/a

PowerShell version and build the target node is running

n/a

Module version used

n/a
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Feb 22, 2025
@johlju johlju mentioned this issue Feb 22, 2025
Open
@IAMJDA IAMJDA linked a pull request Feb 23, 2025 that will close this issue
Open
9 tasks
@IAMJDA
Copy link

IAMJDA commented Feb 23, 2025

I added a PR, but the tests are missing.
PR of course requires PR from #2058 to be successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerPermission: Added support for assigning permissions to a server role. IAMJDA/SqlServerDsc
2 participants
@johlju @IAMJDA