Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDscHelper: The parameters in the helper functions should be renamed #927

Closed
johlju opened this issue Dec 1, 2017 · 1 comment
Closed
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Dec 1, 2017

Details of the scenario you tried and the problem that is occurring:
To align the helper functions with the work being done renaming parameters in issue #308, the parameters in the helper functions should be renamed, where applicable, to ServerName and InstanceName.
For example Connect-SQL is a good example.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Dec 1, 2017
@johlju
Copy link
Member Author

johlju commented Jul 10, 2020

This has been resolved. If there are any function left then we should open an individual issue to track that.

@johlju johlju closed this as completed Jul 10, 2020
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Development

No branches or pull requests

1 participant