Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The deploy fails because there is a space in a tag in the module manifest #280

Closed
johlju opened this issue Oct 28, 2023 · 3 comments · Fixed by #281
Closed

The deploy fails because there is a space in a tag in the module manifest #280

johlju opened this issue Oct 28, 2023 · 3 comments · Fixed by #281
Labels
bug The issue is a bug.

Comments

@johlju
Copy link
Member

johlju commented Oct 28, 2023

The deploy fails because there is a space in the tag that was added in this PR. Dev Drive should be changed to DevDrive in the module manifest (in a new PR): https://github.com/dsccommunity/StorageDsc/pull/278/files#diff-8eee5c09560a979f88c375c8c47f71c0d85a219e61956b96f31efc5988fa2b02R55

See error: https://dev.azure.com/dsccommunity/StorageDsc/_build/results?buildId=8223&view=logs&j=5d0a9c4e-8741-5118-af45-406a30fe661c&t=bda0b158-a237-516f-c1d0-31339587c5b5&l=78

Originally posted by @johlju in #276 (comment)

@johlju johlju added bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. labels Oct 28, 2023
@bbonaby
Copy link
Contributor

bbonaby commented Oct 28, 2023

Thanks @johlju, thats my bad doing a find and replace. Added update PR to fix this in #281

@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Oct 28, 2023
@johlju
Copy link
Member Author

johlju commented Oct 28, 2023

No worries. 🙂 I would have missed this too. We should have a QA test for this, I will suggest that we add one to Sampler, i will add an issue over there too.

@PlagueHO
Copy link
Member

Thanks @johlju and @bbonaby! I remember seeing this at the time and thinking that it was OK. We should also add the test into DSCResource.Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants