Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xStorage - Cannot perform the requested operation when the drive is read only #85

Open
tenletters10 opened this issue Apr 14, 2017 · 18 comments
Labels
bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community.

Comments

@tenletters10
Copy link

tenletters10 commented Apr 14, 2017

When attempting to use 2.9.0.0 I keep getting volumes left in a "raw" volumes with assigned driver letters state even when specifying FSFormat. In the logs I am getting the following errors:

VERBOSE: [localhost]: [[xDisk]Edrive_xDISK] Set-TargetResource: Creat
ing partition on disk number '2' with drive letter 'E' using all free space.
VERBOSE: [localhost]: [[xDisk]Edrive_xDISK] Set-TargetResource: Forma
tting the volume as 'NTFS'.
Cannot perform the requested operation when the drive is read only
+ CategoryInfo : NotSpecified: (StorageWMI:) [], CimException
+ FullyQualifiedErrorId : StorageWMI 43006,Format-Volume
+ PSComputerName : localhost

VERBOSE: [ocalhost]: LCM: [ End Set ] [[xDisk]Edrive_xDISK] in 2.4240 seconds.
The PowerShell DSC resource '[xDisk]Edrive_xDISK' with SourceInfo
'C:\Users\myprofile\Desktop\TestDSC\SSRSDSC.ps1::71::9::xDisk' threw one or more non-terminating
errors while running the Set-TargetResource functionality. These errors are logged to the ETW
channel called Microsoft-Windows-DSC/Operational. Refer to this channel for more details.
+ CategoryInfo : InvalidOperation: (:) [], CimException
+ FullyQualifiedErrorId : NonTerminatingErrorFromProvider
+ PSComputerName : localhost

Below is an example of the config I am using when getting this error:

    xDisk Hdrive_xDISK
    {
         DiskNumber = 5
         DriveLetter = "H"
         FSlabel = "TempDB"
         FSFormat = "NTFS"
         AllocationUnitSize = 65536
         DependsOn = "[xWaitforDisk]Disk5_xDISK"
    }

I can say that if I keep going back and deleting the volume and running the dsc config it will eventually get a correct NTFS volume, but takes about 3 to 5 times before it won't be in a broken state with a "raw" volume. I have also looked at the disk and confirm they are not in read only. Assuming something in the dsc resource is temporarily putting the disk into a read only mode, but as soon as the config is complete and bombs out the disk is not in read only mode.

If I drop back down to my previous version I was using successfully (2.6.0.0), this problem does not exist.

@PlagueHO PlagueHO added bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. labels Apr 15, 2017
@PlagueHO
Copy link
Member

Hi @tenletters10 - thanks for submitting this. Sorry I haven't had a chance to look at this yet. I notice the AllocationUnitSize is 64k - is this a very large disk that is being created/partitioned?

@tenletters10
Copy link
Author

No worries.

The disks are a decent size. I was trying on a various set of sizes (1TB, 2TB, 4TB).

@jdillon-wayfair
Copy link

I can confirm I am seeing the exact same behavior. Adding 3 drives and 3 mountpoints, using xdisk and xmountpoint within foreach loops. xdisk adds the first drive and fails on the second, leaving it raw state and how the exact error stated above. When I manually get through the drives and move onto the mountpoints those work perfect. I then downgraded to 2.6, and xdisk adds the drives perfect, but obviously fails on xmountpoint as that was not part of 2.6. Current work around is script resource instead of xdisk and still load 2.9 so I can utilize the xmountpoint resource.

@PlagueHO
Copy link
Member

Hi @jdillon-wayfair . Thanks for the info! Ill get onto this tonight and hopefully have a solution for you. Are you able to apply the config in verbose mode and upload the output logs here?

@jdillon-wayfair
Copy link

Here is the code snippet followed by the verbose output followed by the screenshot of the drives after the run:
xdisk_github.txt
xdisk_github

@PlagueHO
Copy link
Member

Hi @jdillon-wayfair - I've been looking into this a bit over the weekend and I think the problem may already possibly be fixed in the latest (not yet released) version of xStorage. A new version of this resource should be being released next week (v3.0.0.0) that contains some fixes that may resolve this. Are you able to wait till this new release comes out? If not, feel free to try the Dev branch version in this repo.

Note: this next version will require changes to your config as it does contain a breaking change (see #81)

@jdillon-wayfair
Copy link

That works, as our current work around is a script resource essentially doing similar.
Thanks again for the help and responses here.

@PlagueHO
Copy link
Member

A pleasure to help. Hopefully the new version will be released to master/PS Gallery soon. Are we able to close this issue?

@jdillon-wayfair
Copy link

Update, 3.1 and 3.0 xstorage still has this issue. In fact 3.1 and 3.0 xstorage now breaks xdiskaccesspath for mounting mountpoints stating, "PartitionNumber, The Argument is null". This is with making the change form DiskNumber to DiskID as requested by the Breaking Change release notes

@PlagueHO
Copy link
Member

PlagueHO commented Jun 6, 2017

Hi @jdillon-wayfair - thanks for the update. Are you able to paste a copy of the log output with the PartitionNumber, The Argument is null error so I can try and track the location? Also, could you put the config in here too?

Is this a disk with multiple partitions/volumes or a single partition/volume disk?

@jdillon-wayfair
Copy link

Here is the config:`Configuration testxdisk
{

Import-DscResource -module @{ModuleName="xStorage";RequiredVersion="3.1.0.0"}

Node $AllNodes.NodeName
{
            
    ###Add local admins
    Foreach ($Group in $Node.LocalSecurityGroups)
        {
                    
            Group $Group.Name 
            {
                Ensure = "Present"
                GroupName = $Group.Name
                MembersToInclude = $Group.Members
                Credential = $Credential
            }
        }

    ###Loops through each drive letter and attaches it
    ForEach ($item in $Node.StandAloneDisks) {

        xWaitforDisk "WaitforDisk_$($Node.StandAloneDisks.Indexof($item))"
        {
            DiskID = $item.WaitDiskNumber
            RetryIntervalSec = $item.RetryInterval
            RetryCount = $item.RetryCount
        }
    
        xDisk "Disk_$($Node.StandAloneDisks.Indexof($item))"
            {
                DiskID = $item.disknumber
                Driveletter = $item.driveletter
                FSLabel = $item.fslabel
                AllocationUnitSize = 64kb
            }
    }

    ###Loops through each mountpoint and attaches it
    ForEach ($item in $Node.MountPointDisks) {

        File "SQLFolder_$($Node.MountPointDisks.Indexof($item))"
        {
            Ensure = "Present"
            Type = "Directory"
            DestinationPath = $item.DestinationPath
        }
        
        xDiskAccessPath "DiskaccessPath_$($Node.MountPointDisks.Indexof($item))"
        {
            AccessPath = $item.AccessPath
            AllocationUnitSize = 64kb
            DiskID = $item.MountDiskNumber
            FSLabel = $item.MountFSLabel
            FSFormat = 'NTFS'
            PsDscRunAsCredential = $Credential
        }
    }
}

}`

@jdillon-wayfair
Copy link

jdillon-wayfair commented Jun 6, 2017

And here is the Null Error:

Cannot validate argument on parameter 'PartitionNumber'. The argument is null. Provide a valid value for the argument, and then try running the command again.
+ CategoryInfo : InvalidData: (:) [], CimException
+ FullyQualifiedErrorId : ParameterArgumentValidationError,Add-PartitionAccessPath
+ PSComputerName : MyServer

The PowerShell DSC resource '[xDiskAccessPath]DiskaccessPath_0' with SourceInfo '::101::13::xDiskAccessPath' threw one or more non-terminating errors while running the Set-TargetResource functionality.
These errors are logged to the ETW channel called Microsoft-Windows-DSC/Operational. Refer to this channel for more details.
+ CategoryInfo : InvalidOperation: (:) [], CimException
+ FullyQualifiedErrorId : NonTerminatingErrorFromProvider
+ PSComputerName : MyServer

@PlagueHO
Copy link
Member

PlagueHO commented Jun 9, 2017

Thanks @jdillon-wayfair - that didn't quite provide what I'd hoped. What I was wanting to see was the Verbose log output so that I could track the code path through the resource. Is there any chance you could run this with the verbose log output enabled? E.g. using something like this?

Start-DscConfiguration -Path . -ComputerName localhost -Wait -Verbose -Force

It will then provide lots more detail as to what code is being called.

@jdillon-wayfair
Copy link

VERBOSE: [testserver]: LCM: [ Start Resource ] [[xWaitForDisk]WaitforDisk_0]
VERBOSE: [testserver]: LCM: [ Start Test ] [[xWaitForDisk]WaitforDisk_0]
VERBOSE: [testserver]: [[xWaitForDisk]WaitforDisk_0] Test-TargetResource: Checking for disk with Number '1'.
VERBOSE: [testserver]: [[xWaitForDisk]WaitforDisk_0] Test-TargetResource: Found disk with Number '1' named 'VMware
Virtual disk SCSI Disk Device'.
VERBOSE: [testserver]: LCM: [ End Test ] [[xWaitForDisk]WaitforDisk_0] in 0.0160 seconds.
VERBOSE: [testserver]: LCM: [ Skip Set ] [[xWaitForDisk]WaitforDisk_0]
VERBOSE: [testserver]: LCM: [ End Resource ] [[xWaitForDisk]WaitforDisk_0]
VERBOSE: [testserver]: LCM: [ Start Resource ] [[xDisk]Disk_0]
VERBOSE: [testserver]: LCM: [ Start Test ] [[xDisk]Disk_0]
VERBOSE: [testserver]: [[xDisk]Disk_0] Test-TargetResource: Testing disk with Number '1' status for drive letter 'H
'.
VERBOSE: [testserver]: [[xDisk]Disk_0] Test-TargetResource: Checking if disk with Number '1' is initialized.
VERBOSE: [testserver]: [[xDisk]Disk_0] Test-TargetResource: Drive H was not found.
VERBOSE: [testserver]: LCM: [ End Test ] [[xDisk]Disk_0] in 0.0470 seconds.
VERBOSE: [testserver]: LCM: [ Start Set ] [[xDisk]Disk_0]
VERBOSE: [testserver]: [[xDisk]Disk_0] Set-TargetResource: Setting disk with Number '1' status for drive letter 'H'
.
VERBOSE: [testserver]: [[xDisk]Disk_0] Set-TargetResource: Checking disk with Number '1' partition style.
VERBOSE: [testserver]: [[xDisk]Disk_0] Set-TargetResource: Disk with Number '1' is already initialized with GPT.
VERBOSE: [testserver]: [[xDisk]Disk_0] Set-TargetResource: Disk with Number '1' does not contain a partition assign
ed to drive letter 'H'.
VERBOSE: [testserver]: [[xDisk]Disk_0] Set-TargetResource: Creating partition on disk with Number '1' with drive le
tter 'H' using all free space.
VERBOSE: [testserver]: [[xDisk]Disk_0] Set-TargetResource: Formatting the volume as 'NTFS'.
VERBOSE: [testserver]: LCM: [ End Set ] [[xDisk]Disk_0] in 0.9370 seconds.
VERBOSE: [testserver]: LCM: [ End Resource ] [[xDisk]Disk_0]
VERBOSE: [testserver]: LCM: [ Start Resource ] [[xWaitForDisk]WaitforDisk_1]
VERBOSE: [testserver]: LCM: [ Start Test ] [[xWaitForDisk]WaitforDisk_1]
VERBOSE: [testserver]: [[xWaitForDisk]WaitforDisk_1] Test-TargetResource: Checking for disk with Number '2'.
VERBOSE: [testserver]: [[xWaitForDisk]WaitforDisk_1] Test-TargetResource: Found disk with Number '2' named 'VMware
Virtual disk SCSI Disk Device'.
VERBOSE: [testserver]: LCM: [ End Test ] [[xWaitForDisk]WaitforDisk_1] in 0.0160 seconds.
VERBOSE: [testserver]: LCM: [ Skip Set ] [[xWaitForDisk]WaitforDisk_1]
VERBOSE: [testserver]: LCM: [ End Resource ] [[xWaitForDisk]WaitforDisk_1]
VERBOSE: [testserver]: LCM: [ Start Resource ] [[xDisk]Disk_1]
VERBOSE: [testserver]: LCM: [ Start Test ] [[xDisk]Disk_1]
VERBOSE: [testserver]: [[xDisk]Disk_1] Test-TargetResource: Testing disk with Number '2' status for drive letter 'W
'.
VERBOSE: [testserver]: [[xDisk]Disk_1] Test-TargetResource: Checking if disk with Number '2' is initialized.
VERBOSE: [testserver]: [[xDisk]Disk_1] Test-TargetResource: Drive W was not found.
VERBOSE: [testserver]: LCM: [ End Test ] [[xDisk]Disk_1] in 0.0150 seconds.
VERBOSE: [testserver]: LCM: [ Start Set ] [[xDisk]Disk_1]
VERBOSE: [testserver]: [[xDisk]Disk_1] Set-TargetResource: Setting disk with Number '2' status for drive letter 'W'
.
VERBOSE: [testserver]: [[xDisk]Disk_1] Set-TargetResource: Checking disk with Number '2' partition style.
VERBOSE: [testserver]: [[xDisk]Disk_1] Set-TargetResource: Disk with Number '2' is already initialized with GPT.
VERBOSE: [testserver]: [[xDisk]Disk_1] Set-TargetResource: Disk with Number '2' does not contain a partition assign
ed to drive letter 'W'.
VERBOSE: [testserver]: [[xDisk]Disk_1] Set-TargetResource: Creating partition on disk with Number '2' with drive le
tter 'W' using all free space.
VERBOSE: [testserver]: [[xDisk]Disk_1] Set-TargetResource: Formatting the volume as 'NTFS'.
Cannot perform the requested operation when the drive is read only
+ CategoryInfo : NotSpecified: (StorageWMI:) [], CimException
+ FullyQualifiedErrorId : StorageWMI 43006,Format-Volume
+ PSComputerName : testserver

VERBOSE: [testserver]: LCM: [ End Set ] [[xDisk]Disk_1] in 0.3750 seconds.
The PowerShell DSC resource '[xDisk]Disk_1' with SourceInfo '::33::9::xDisk' threw one or more non-terminating errors while running the
Set-TargetResource functionality. These errors are logged to the ETW channel called Microsoft-Windows-DSC/Operational. Refer to this channel
for more details.
+ CategoryInfo : InvalidOperation: (:) [], CimException
+ FullyQualifiedErrorId : NonTerminatingErrorFromProvider
+ PSComputerName : testserver

VERBOSE: [testserver]: LCM: [ Start Resource ] [[File]SQLFolder_0]
VERBOSE: [testserver]: LCM: [ Start Test ] [[File]SQLFolder_0]
VERBOSE: [testserver]: [[File]SQLFolder_0] The volume does not contain a recognized file system.
Please make sure that all required file system drivers are loaded and that the volume is not corrupted.
VERBOSE: [testserver]: [[File]SQLFolder_0] The related file/directory is: W:\SQL\Binaries.
The volume does not contain a recognized file system.
Please make sure that all required file system drivers are loaded and that the volume is not corrupted. The related file/directory is:
W:\SQL\Binaries.
+ CategoryInfo : NotSpecified: (:) [], CimException
+ FullyQualifiedErrorId : Windows System Error 1005
+ PSComputerName : testserver

VERBOSE: [testserver]: LCM: [ Start Resource ] [[xDiskAccessPath]DiskaccessPath_0]
VERBOSE: [testserver]: LCM: [ Start Test ] [[xDiskAccessPath]DiskaccessPath_0]
VERBOSE: [testserver]: [[xDiskAccessPath]DiskaccessPath_0] Test-TargetResource: Testing disk with Number '3' status
for access path 'W:\SQL\Binaries'.
VERBOSE: [testserver]: LCM: [ End Test ] [[xDiskAccessPath]DiskaccessPath_0] in 0.9850 seconds.
PowerShell DSC resource MSFT_xDiskAccessPath failed to execute Test-TargetResource functionality with error message: Access Path
'W:\SQL\Binaries' is not found.
Parameter name: AccessPath
+ CategoryInfo : InvalidOperation: (:) [], CimException
+ FullyQualifiedErrorId : ProviderOperationExecutionFailure
+ PSComputerName : testserver

VERBOSE: [testserver]: LCM: [ End Set ]
The SendConfigurationApply function did not succeed.
+ CategoryInfo : NotSpecified: (root/Microsoft/...gurationManager:String) [], CimException
+ FullyQualifiedErrorId : MI RESULT 1
+ PSComputerName : testserver

VERBOSE: Operation 'Invoke CimMethod' complete.
VERBOSE: Time taken for configuration job to complete is 5.219 seconds

@PlagueHO
Copy link
Member

Thanks @jdillon-wayfair - sorry about taking so long. I'll go through this tomorrow night after work and see if I can figure out exactly what is going on here. Thanks again for your patience and assistance!

@oribesser
Copy link

oribesser commented Dec 17, 2017

Hi,
I have the same issue (version 3.3.0.0) with this configuration, it seems to always happen with the T volume:

xWaitforDisk Disk1
{
    DiskId           = 1
    RetryIntervalSec = 30
    RetryCount       = 2
}

xWaitforDisk Disk2
{
    DiskId           = 2
    RetryIntervalSec = 30
    RetryCount       = 2
}

xWaitforDisk Disk3
{
    DiskId           = 3
    RetryIntervalSec = 30
    RetryCount       = 2
}

xDisk DVolume
{
    DiskId      = 1
    DriveLetter = 'D'
    AllocationUnitSize = 64KB
    DependsOn   = '[xWaitForDisk]Disk1'
        
}

xDisk TVolume
{
    DiskId      = 2
    DriveLetter = 'T'
    AllocationUnitSize = 64KB
    DependsOn   = '[xWaitForDisk]Disk2'
}

xDisk LVolume
{
    DiskId      = 3
    DriveLetter = 'L'
    AllocationUnitSize = 64KB
    DependsOn   = '[xWaitForDisk]Disk3'
}

The verbose output is:

LCM: [ Start Resource ] [[xWaitForDisk]Disk1]
LCM: [ Start Test ] [[xWaitForDisk]Disk1]
[[xWaitForDisk]Disk1] Test-TargetResource: Checking for disk with Number '1'.
[[xWaitForDisk]Disk1] Test-TargetResource: Found disk with Number '1' named 'VMware Virtual disk SCSI Disk Device'.
LCM: [ End Test ] [[xWaitForDisk]Disk1] in 0.8750 seconds.
LCM: [ Skip Set ] [[xWaitForDisk]Disk1]
LCM: [ End Resource ] [[xWaitForDisk]Disk1]
LCM: [ Start Resource ] [[xWaitForDisk]Disk2]
LCM: [ Start Test ] [[xWaitForDisk]Disk2]
[[xWaitForDisk]Disk2] Test-TargetResource: Checking for disk with Number '2'.
[[xWaitForDisk]Disk2] Test-TargetResource: Found disk with Number '2' named 'VMware Virtual disk SCSI Disk Device'.
LCM: [ End Test ] [[xWaitForDisk]Disk2] in 0.0160 seconds.
LCM: [ Skip Set ] [[xWaitForDisk]Disk2]
LCM: [ End Resource ] [[xWaitForDisk]Disk2]
LCM: [ Start Resource ] [[xWaitForDisk]Disk3]
LCM: [ Start Test ] [[xWaitForDisk]Disk3]
[[xWaitForDisk]Disk3] Test-TargetResource: Checking for disk with Number '3'.
[[xWaitForDisk]Disk3] Test-TargetResource: Found disk with Number '3' named 'VMware Virtual disk SCSI Disk Device'.
LCM: [ End Test ] [[xWaitForDisk]Disk3] in 0.0160 seconds.
LCM: [ Skip Set ] [[xWaitForDisk]Disk3]
LCM: [ End Resource ] [[xWaitForDisk]Disk3]
LCM: [ Start Resource ] [[xDisk]DVolume]
LCM: [ Start Test ] [[xDisk]DVolume]
[[xDisk]DVolume] Test-TargetResource: Testing disk with Number '1' status for drive letter 'D'.
[[xDisk]DVolume] Test-TargetResource: Checking if disk with Number '1' is initialized.
[[xDisk]DVolume] Test-TargetResource: Drive D was not found.
LCM: [ End Test ] [[xDisk]DVolume] in 0.1090 seconds.
LCM: [ Start Set ] [[xDisk]DVolume]
[[xDisk]DVolume] Set-TargetResource: Setting disk with Number '1' status for drive letter 'D'.
[[xDisk]DVolume] Set-TargetResource: Checking disk with Number '1' partition style.
[[xDisk]DVolume] Set-TargetResource: Disk with Number '1' is already initialized with GPT.
[[xDisk]DVolume] Set-TargetResource: Disk with Number '1' does not contain a partition assigned to drive letter 'D'.
[[xDisk]DVolume] Set-TargetResource: Creating partition on disk with Number '1' with drive letter 'D' using all free space.
[[xDisk]DVolume] Set-TargetResource: Formatting the volume as 'NTFS'.
LCM: [ End Set ] [[xDisk]DVolume] in 1.5000 seconds.
LCM: [ End Resource ] [[xDisk]DVolume]
LCM: [ Start Resource ] [[xDisk]TVolume]
LCM: [ Start Test ] [[xDisk]TVolume]
[[xDisk]TVolume] Test-TargetResource: Testing disk with Number '2' status for drive letter 'T'.
[[xDisk]TVolume] Test-TargetResource: Checking if disk with Number '2' is initialized.
[[xDisk]TVolume] Test-TargetResource: Drive T was not found.
LCM: [ End Test ] [[xDisk]TVolume] in 0.0310 seconds.
LCM: [ Start Set ] [[xDisk]TVolume]
[[xDisk]TVolume] Set-TargetResource: Setting disk with Number '2' status for drive letter 'T'.
[[xDisk]TVolume] Set-TargetResource: Checking disk with Number '2' partition style.
[[xDisk]TVolume] Set-TargetResource: Disk with Number '2' is already initialized with GPT.
[[xDisk]TVolume] Set-TargetResource: Disk with Number '2' does not contain a partition assigned to drive letter 'T'.
[[xDisk]TVolume] Set-TargetResource: Creating partition on disk with Number '2' with drive letter 'T' using all free space.
[[xDisk]TVolume] Set-TargetResource: Formatting the volume as 'NTFS'.
Cannot perform the requested operation when the drive is read only
+ CategoryInfo : NotSpecified: (StorageWMI:) [], CimException
+ FullyQualifiedErrorId : StorageWMI 43006,Format-Volume
+ PSComputerName : tmplt-test
DiskId = 3
VERBOSE: [TMPLT-TEST]: LCM: [ End Set ] [[xDisk]TVolume] in 1.0620 seconds.
The PowerShell DSC resource '[xDisk]TVolume' with SourceInfo '::53::9::xDisk' threw one or more non-terminating errors while running the Set-TargetResource functionality. These errors are logged to the ETW channel calle
d Microsoft-Windows-DSC/Operational. Refer to this channel for more details.
+ CategoryInfo : InvalidOperation: (:) [], CimException
+ FullyQualifiedErrorId : NonTerminatingErrorFromProvider
+ PSComputerName : tmplt-test
{
LCM: [ Start Resource ] [[xDisk]LVolume]
LCM: [ Start Test ] [[xDisk]LVolume]
[[xDisk]LVolume] Test-TargetResource: Testing disk with Number '3' status for drive letter 'L'.
[[xDisk]LVolume] Test-TargetResource: Checking if disk with Number '3' is initialized.
[[xDisk]LVolume] Test-TargetResource: Drive L was not found.
LCM: [ End Test ] [[xDisk]LVolume] in 0.0310 seconds.
LCM: [ Start Set ] [[xDisk]LVolume]
[[xDisk]LVolume] Set-TargetResource: Setting disk with Number '3' status for drive letter 'L'.
[[xDisk]LVolume] Set-TargetResource: Checking disk with Number '3' partition style.
[[xDisk]LVolume] Set-TargetResource: Disk with Number '3' is already initialized with GPT.
[[xDisk]LVolume] Set-TargetResource: Disk with Number '3' does not contain a partition assigned to drive letter 'L'.
[[xDisk]LVolume] Set-TargetResource: Creating partition on disk with Number '3' with drive letter 'L' using all free space.
[[xDisk]LVolume] Set-TargetResource: Formatting the volume as 'NTFS'.
LCM: [ End Set ] [[xDisk]LVolume] in 1.0940 seconds.
LCM: [ End Resource ] [[xDisk]LVolume]

@PlagueHO
Copy link
Member

Hi @oribesser - this should be resolved once I can get this PR through: #126

Just needs merge conflicts resolved and it should be able to be merged.

@JoshuaJSwain
Copy link
Contributor

I have a pull request up for this issue #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Development

No branches or pull requests

5 participants