Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running run configurations with dstack apply #1326

Closed
r4victor opened this issue Jun 12, 2024 · 2 comments · Fixed by #1454
Closed

Support running run configurations with dstack apply #1326

r4victor opened this issue Jun 12, 2024 · 2 comments · Fixed by #1454
Assignees
Labels

Comments

@r4victor
Copy link
Collaborator

#1223 allowed creating/updating gateways via dstack apply. Similarly, dstack apply should work for runs. It will accept a run configuration as

dstack apply -f service.dstack.yml

If the run configuration doesn't specify a run name, dstack apply will work just like dstack run – create a new run with a random name. If the run name is specified, then dstack apply will create/re-create the run with the specified name. dstack apply can have configuration-specific arguments and accept the same arguments as dstack run.

Required changes:

  • Add name field to run configuration so that users can specify run names in yaml.
  • dstack run requires working_dir positional argument that serves two purposes: 1) it's used as the working dir of the container and 2) run configuration is searched relative two it. dstack apply doesn't have required working_dir. The working_dir of the container should be specified via a new run configuration parameter. The run configuration search doesn't need to be done with respect to some specific working_dir – only with respect to cwd – so this can be dropped.
@r4victor
Copy link
Collaborator Author

Currently, resource specification via dstack run CLI arguments is very limited. cpu and memory are not supported. This can be fixed if the CLI arguments unified with dstack pool add. This could probably be done together with #1327

@r4victor r4victor mentioned this issue Jun 12, 2024
41 tasks
@peterschmidt85
Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants