Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Python helper script/function to transform point_data objects to met_point_data objects for Python Embedding #2302

Closed
6 of 21 tasks
DanielAdriaansen opened this issue Oct 14, 2022 · 1 comment · Fixed by #2340
Assignees
Labels
MET: Python Embedding priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NCAR/RAL NCAR Research Applications Laboratory type: enhancement Improve something that it is currently doing
Milestone

Comments

@DanielAdriaansen
Copy link
Contributor

DanielAdriaansen commented Oct 14, 2022

Describe the Enhancement

Write a new Python helper script to take a point_data object and transform it to a met_point_data object, to avoid the user having to use ASCII2NC with Python Embedding prior to calling another MET tool.

The workflow would look like this:

  1. User Python script is executed that constructs a point_data object
  2. User can import functions from this Python helper script to convert point_data to met_point_data
  3. The user is returned a met_point_data object which can then be handed off directly to MET tools such as point_stat

This work is a stop-gap to provide users functionality faster than the work described in #2285

Time Estimate

TBD

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2799992 NRL Aerosol Prof

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@DanielAdriaansen DanielAdriaansen added type: enhancement Improve something that it is currently doing alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle MET: Python Embedding labels Oct 14, 2022
@DanielAdriaansen DanielAdriaansen added this to the MET 11.0.0 milestone Oct 14, 2022
@DanielAdriaansen DanielAdriaansen self-assigned this Oct 14, 2022
@DanielAdriaansen DanielAdriaansen added requestor: NCAR/RAL NCAR Research Applications Laboratory priority: high High Priority labels Oct 14, 2022
@DanielAdriaansen
Copy link
Contributor Author

@hsoh-u please add any details I may have left out, or edit the issue description if I have misrepresented the idea. Thanks!

@hsoh-u hsoh-u moved this from Backlog to In Progress in MET-11.0.0-beta5 (11/20/22) Oct 28, 2022
@TaraJensen TaraJensen removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Oct 28, 2022
@JohnHalleyGotway JohnHalleyGotway removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Nov 3, 2022
@JohnHalleyGotway JohnHalleyGotway moved this from In Progress to Pull Request Review in MET-11.0.0-beta5 (11/20/22) Nov 10, 2022
@hsoh-u hsoh-u linked a pull request Nov 16, 2022 that will close this issue
15 tasks
@hsoh-u hsoh-u closed this as completed Nov 18, 2022
Repository owner moved this from Pull Request Review to Done in MET-11.0.0-beta5 (11/20/22) Nov 18, 2022
@TaraJensen TaraJensen added the reporting: DTC NOAA R2O NOAA Research to Operations DTC Project label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Python Embedding priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NCAR/RAL NCAR Research Applications Laboratory type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants