Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Differences from TCI use case (again) #2834

Open
24 tasks
DanielAdriaansen opened this issue Dec 13, 2024 · 0 comments · Fixed by #2836
Open
24 tasks

Bugfix: Differences from TCI use case (again) #2834

DanielAdriaansen opened this issue Dec 13, 2024 · 0 comments · Fixed by #2836
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue type: bug Fix something that is not working
Milestone

Comments

@DanielAdriaansen
Copy link
Contributor

DanielAdriaansen commented Dec 13, 2024

See here dtcenter/MET#2897 for background on the previous issue. At the time that issue was being investigated, @georgemccabe suggested sorting a file listing returned from glob in Python embedding. I think that suggestion got lost after uncovering the bug in MET Python embedding for point observations. This issue is to sort the file list returned from glob in the Python embedding script for point observations from FLUXNET files used to compute TCI.

Describe the Problem

Provide a clear and concise description of the bug here.

Expected Behavior

Provide a clear and concise description of what you expected to happen here.

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next bugfix version
  • Select Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Select METplus-Wrappers-X.Y.Z Development project for development toward the next official release

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.

  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>

  • Fix the bug and test your changes.

  • Add/update log messages for easier debugging.

  • Add/update unit tests.

  • Add/update documentation.

  • Add any new Python packages to the METplus Components Python Requirements table.

  • Push local changes to GitHub.

  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>

  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next bugfix version
    Select: Coordinated METplus-X.Y Support project for support of the current coordinated release

  • Iterate until the reviewer(s) accept and merge your changes.

  • Delete your fork or branch.

  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: METplus-Wrappers-X.Y.Z Development project for development toward the next official release

  • Close this issue.

@DanielAdriaansen DanielAdriaansen added type: bug Fix something that is not working alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Dec 13, 2024
@DanielAdriaansen DanielAdriaansen added this to the METplus-6.0.0 milestone Dec 13, 2024
@DanielAdriaansen DanielAdriaansen self-assigned this Dec 13, 2024
@DanielAdriaansen DanielAdriaansen changed the title Bugfix: Differences from TCI use case Bugfix: Differences from TCI use case (again) Dec 13, 2024
@DanielAdriaansen DanielAdriaansen moved this from 🩺 Needs Triage to 🔎 In review in METplus-Wrappers-6.0.0 Development Dec 13, 2024
@DanielAdriaansen DanielAdriaansen linked a pull request Dec 13, 2024 that will close this issue
16 tasks
georgemccabe added a commit that referenced this issue Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue type: bug Fix something that is not working
Projects
Status: 🔎 In review
Development

Successfully merging a pull request may close this issue.

1 participant