-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify user diagnostic feature relative use case to use MetPy Python package #759
Comments
@lindsayrblank were you working in a feature branch by chance? If not, could you point us to the two scripts mentioned in the issue description? And Tara mentioned you were working with MetPy on some questions- is there a GitHub issue in the MetPy repository or a discussion board in their repository where that conversation is documented or was it just via email so far? Thanks! |
@DanielAdriaansen Hi Dan, I was not in working in a feature branch, unfortunately. I was first trying to get things working with an example to then implement into METplus, but that never happened. The scripts, including what I've done so far with MetPy are here: eyewall:/d1/lblank/SBU/metpy. As for the conversation, it was through email. I have forwarded that to you. Let me know if you need anything else! |
Thanks @lindsayrblank! What version of MetPy were you using to develop with? And are there any requirements or restrictions I should know about? It looks like you're using pygrib and wondered if that was required or whether other options were OK. Was the sample GFS file provided for you? Also- I thought both of the scripts listed in this issue description were provided to you and |
@DanielAdriaansen No problem! Here are all the answers to your questions.
|
Working on branch feature_759_FR_MetPy. We will be eliminating this use case: by:
|
Describe the New Feature
Brian Colle from SBU wants us to change the user diagnostic input scripts to use MetPy. This means re-writing the follow scripts:
We should use the following function: https://unidata.github.io/MetPy/latest/api/generated/metpy.calc.potential_vorticity_baroclinic.html
I have tried to do this myself, but the required format (P,M,N) is giving me trouble.
Acceptance Testing
Data: input data for TCStat_SeriesAnalysis_fcstGFS_obsGFS_FeatureRelative_SeriesByLead_PyEmbed_IVT.conf
Tests: Make sure the previous output of user diagnostic PyEmbedIngest match the output generated with MetPy in the scripts.
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
TBD
Sub-Issues
Consider breaking the new feature down into sub-issues.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
7791041 - SBU Key
Define the Metadata
Assignee
Labels
Projects and Milestone
Define Related Issue(s)
Consider the impact to the other METplus components.
New Feature Checklist
See the METplus Workflow for details.
Branch name:
feature_<Issue Number>_<Description>
Pull request:
feature <Issue Number> <Description>
Select: Reviewer(s), Project(s), Milestone, and Linked issues
The text was updated successfully, but these errors were encountered: