Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify user diagnostic feature relative use case to use MetPy Python package #759

Closed
1 of 21 tasks
lindsayrblank opened this issue Jan 12, 2021 · 6 comments · Fixed by #1025
Closed
1 of 21 tasks

Modify user diagnostic feature relative use case to use MetPy Python package #759

lindsayrblank opened this issue Jan 12, 2021 · 6 comments · Fixed by #1025
Assignees
Labels
alert: NEED MORE DEFINITION Not yet actionable, additional definition required METplus: Configuration priority: high High Priority requestor: University/SBU Stony Brook University required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing type: new feature Make it do something new
Milestone

Comments

@lindsayrblank
Copy link

lindsayrblank commented Jan 12, 2021

Describe the New Feature

Brian Colle from SBU wants us to change the user diagnostic input scripts to use MetPy. This means re-writing the follow scripts:

  • gfs_pv_analysis.py
  • gfs_pv_fcst.py

We should use the following function: https://unidata.github.io/MetPy/latest/api/generated/metpy.calc.potential_vorticity_baroclinic.html

I have tried to do this myself, but the required format (P,M,N) is giving me trouble.

Acceptance Testing

Data: input data for TCStat_SeriesAnalysis_fcstGFS_obsGFS_FeatureRelative_SeriesByLead_PyEmbed_IVT.conf
Tests: Make sure the previous output of user diagnostic PyEmbedIngest match the output generated with MetPy in the scripts.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
TBD

Sub-Issues

Consider breaking the new feature down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

7791041 - SBU Key

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: Need to define who this is
  • Select scientist(s) or no scientist required: Lindsay and Tara

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

New Feature Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@lindsayrblank lindsayrblank added type: enhancement Improve something that it is currently doing component: use case configuration priority: high High Priority type: new feature Make it do something new alert: NEED MORE DEFINITION Not yet actionable, additional definition required requestor: University/SBU Stony Brook University labels Jan 12, 2021
@TaraJensen TaraJensen added this to the METplus-4.1.0 milestone Apr 13, 2021
@DanielAdriaansen
Copy link
Contributor

@lindsayrblank were you working in a feature branch by chance? If not, could you point us to the two scripts mentioned in the issue description? And Tara mentioned you were working with MetPy on some questions- is there a GitHub issue in the MetPy repository or a discussion board in their repository where that conversation is documented or was it just via email so far? Thanks!

@lindsayrblank
Copy link
Author

@DanielAdriaansen Hi Dan, I was not in working in a feature branch, unfortunately. I was first trying to get things working with an example to then implement into METplus, but that never happened. The scripts, including what I've done so far with MetPy are here: eyewall:/d1/lblank/SBU/metpy. As for the conversation, it was through email. I have forwarded that to you. Let me know if you need anything else!

@DanielAdriaansen
Copy link
Contributor

DanielAdriaansen commented Apr 14, 2021

Thanks @lindsayrblank! What version of MetPy were you using to develop with? And are there any requirements or restrictions I should know about? It looks like you're using pygrib and wondered if that was required or whether other options were OK.

Was the sample GFS file provided for you?

Also- I thought both of the scripts listed in this issue description were provided to you and gfs_pv_fcst_metpy.py was your adaptation but it looks like all the scripts are your scripts?

@DanielAdriaansen DanielAdriaansen added the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Apr 14, 2021
@TaraJensen TaraJensen removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Apr 14, 2021
@lindsayrblank
Copy link
Author

@DanielAdriaansen No problem! Here are all the answers to your questions.

  1. I was using MetPy v1.0.
  2. There are no requirements that I can think of!
  3. You do not have to use pygrib.
  4. The sample GFS file is one file from the larger Dorian GFS data (eyewall:/d1/lblank/SBU/dorian_data/model_data)
  5. All of the scripts were originally provided to me by a graduate student at Stony Brook. I then adapted them for use by METplus for python embedding. The original scientific (the PV calculation) logic was not mine. I was then instructed by our sponsor to change everything to MetPy.

@TaraJensen TaraJensen added required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels May 17, 2021
@TaraJensen TaraJensen removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Jun 8, 2021
@georgemccabe georgemccabe changed the title Set up User Diagnostic Feature Relative Use Case to use MetPy Modify user diagnostic feature relative use case to use MetPy Python package Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED MORE DEFINITION Not yet actionable, additional definition required METplus: Configuration priority: high High Priority requestor: University/SBU Stony Brook University required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing type: new feature Make it do something new
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants