-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocol and profile versions are not float #56
Comments
fundthmcalculus
added a commit
to fundthmcalculus/python-fitparse
that referenced
this issue
Nov 1, 2021
PR to address this here: #135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
FitFile.protocol_version, profile_version
are just strings "major.minor" (i.e. "int dot int" format), not floats. Floats are inaccurate representations.I propose to create a custom class
FitVersion
with fieldsmajor, minor
and__str__
func with proper formatting. And maybe magic functions for comparison (__eq__
,__gt__
, ...). Can make a PR for that.The text was updated successfully, but these errors were encountered: