Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemtranslation.com Parser Broke + 69Shuba Change #1458

Closed
X-Xadro opened this issue Sep 4, 2024 · 6 comments
Closed

systemtranslation.com Parser Broke + 69Shuba Change #1458

X-Xadro opened this issue Sep 4, 2024 · 6 comments

Comments

@X-Xadro
Copy link

X-Xadro commented Sep 4, 2024

URL Tested: https://systemtranslation.com/series/dragon-ball-god-mu/

Result:
2024-09-04 03_35_08-WebToEpub

URL Tested: https://69shu.me/book/44386.htm

The domain for 69Shuba changed again, but the parser still works, however the chapter list is in reverse order.

Also shown in that screenshot is that it adds the Novel main overview page to the chapter list:

<a href="https://69shu.me/book/44386.htm">你管这叫幕后黑手?目录</a>
<a href="https://69shu.me/txt/44386/31277804">完本感言</a>
<a href="https://69shu.me/txt/44386/31277733">第396章 所谓不朽(大结局)</a>
<a href="https://69shu.me/txt/44386/31272337">第395章 突如其来的权柄</a>

2024-09-04 03_39_02-WebToEpub

The 69Shuba is a small thing because you can reverse the list order with the button and just uncheck the novel main page from the chapter list. But since i was posting an issue anyway....

Thanks for your hard work!

@gamebeaker
Copy link
Collaborator

@X-Xadro Test versions for Firefox and Chrome have been uploaded to https://github.com/dteviot/WebToEpub/releases/tag/developer-build. Pick the one suitable for you, follow the "How to install from Source (for people who are not developers)" instructions at https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode#user-content-how-to-install-from-source-for-people-who-are-not-developers and let me know how it goes.
Tested with:

@dteviot
Copy link
Owner

dteviot commented Sep 4, 2024

@X-Xadro
In future, please create separate issue for each site. Makes keeping track of the work easier when it can't all be done at once.

@gamebeaker,
FWIW, we can probably remove the SystemTranslationParser. Anything using the eplister should be able to be handled by NoblemtlParser now.

@X-Xadro
Copy link
Author

X-Xadro commented Sep 4, 2024

@gamebeaker Tested it and both work, thanks!

@dteviot Will do!

@gamebeaker
Copy link
Collaborator

@X-Xadro is this #1359 still a problem?

@X-Xadro
Copy link
Author

X-Xadro commented Sep 4, 2024

@gamebeaker

@X-Xadro is this #1359 still a problem?

A couple days ago i re-downloaded the novel which i had issues with before because it had new chapters and just now I checked a couple chapters, including the one that was broken for me last time. And it was exactly like on site itself. So it seems to be 'fixed'

A while ago they also had a different protection where they pasted your IP address in the chapters if you used a downloader to get the story. So i guess they are experimenting or the site changes hands with every domain change lol

@dteviot
Copy link
Owner

dteviot commented Sep 26, 2024

@X-Xadro
Updated version (1.0.0.0) has been submitted to Firefox and Chrome stores.
Firefox version is available now.
Chrome might be available in a few hours to 21 days.

@dteviot dteviot closed this as completed Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants