-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it possible to use a pure rust lib rather than onig? #74
Comments
This crate doesn't use onig, it is pulled in through syntect. I am sad about it too. trishume/syntect#12 |
Seems like soonish there might be a fancy-regex feature: trishume/syntect#270 Sent with GitHawk |
The Still hoping that onig's build will eventually improve but for now |
Even as a feature that’s helpful. Ideally a bit of the readme can just say for the max-rust version do ‘X’. Sent with GitHawk |
I've already added such a section to the Readme :) |
Thanks - I was thinking of the readme for cargo-expand as that’s where people will look for it initially. Sent with GitHawk |
Fixed in 0.5.0. |
Beautiful, thanks to everyone involved! |
Is it possible to use a pure rust lib rather than onig? I'm mostly asking this question so that the answer is documented. When it's not pure rust people can have trouble compiling with gcc on windows on gnu toolchain - it requires more setup and configuration of a windows machine than just installing rustup.
As I said I'm sure there's some good reasons behind using onig versus depending on some parts of ripgrep, just would be nice to know so that I can stop wondering.... :-)
The text was updated successfully, but these errors were encountered: