Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide member function bool empty() const noexcept on rust::Str, rust::String #853

Closed
dtolnay opened this issue Apr 27, 2021 · 0 comments · Fixed by #854
Closed

Provide member function bool empty() const noexcept on rust::Str, rust::String #853

dtolnay opened this issue Apr 27, 2021 · 0 comments · Fixed by #854

Comments

@dtolnay
Copy link
Owner

dtolnay commented Apr 27, 2021

We apparently already have this on rust::Slice and rust::Vec but it isn't there on rust::Str and rust::String.

cxx/include/cxx.h

Line 168 in 1d0556e

bool empty() const noexcept;

cxx/include/cxx.h

Line 300 in 1d0556e

bool empty() const noexcept;

Should match the API of https://en.cppreference.com/w/cpp/string/basic_string/empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add bool empty() const noexcept to Str, String dtolnay/cxx
1 participant
@dtolnay