partialEq for Span

[pkpkpk]

This was added in #68 and has since been removed. Can it be re-introduced or put under a flag?

[dtolnay]

We follow the API of the compiler's proc_macro::Span. It looks like proc_macro::Span had PartialEq back when #68 was merged but no longer does. Could you help track down where it was removed upstream to confirm the reason?

[pkpkpk]

Ok I will try!

[pkpkpk]

Looks like it was removed here: reorganize public API

[dtolnay]

Could you say more about your use case for this impl? Then we can check with alexcrichton or petrochenkov how we can support that use case. What is your code doing that needs PartialEq on Span?

[pkpkpk]

I am trying to write fixtures and tests for some parsing code similar to wasm-bindgen's parser. Incidentally, the removal of partialeq breaks WB's 'extra-traits' feature.

[dtolnay]

Is there any meaning to comparing the spans in that case, or is it only to make it convenient to derive PartialEq rather than implement by hand in a way that ignores spans?

[dtolnay]

Closing as this was rejected in rust-lang/rust#59070.