-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent "indexed-ness" for columns when using within and outside a proc-macro environment #326
Comments
samuelpilz
changed the title
off-by-one in the docs for LineColumn
off-by-one error in the docs for LineColumn
Apr 21, 2022
Looking at the tests, when using the |
samuelpilz
changed the title
off-by-one error in the docs for LineColumn
Inconsistent "indexed-ness" for columns when using within and outside a proc-macro environment
Mar 25, 2023
Yeah it seems this got changed in libproc_macro in rust-lang/rust#87712. |
can I help fixing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This crates docs for
LineColumn
say that the column is 0-indexed. The docs forproc_macro::LineColumn
say that the column is 1-indexed. As far as I can see, this is a documentation issue in proc_macro2 and the column value from theproc_macro::LineColumn
is used without offset.The text was updated successfully, but these errors were encountered: