Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiation of literals #26

Open
dtolnay opened this issue Nov 9, 2019 · 0 comments
Open

Instantiation of literals #26

dtolnay opened this issue Nov 9, 2019 · 0 comments

Comments

@dtolnay
Copy link
Owner

dtolnay commented Nov 9, 2019

Before introducing a thread_local WipFunction in #13, the only way for us to attach literals into the right WipFunction was by constructing them through methods of MakeFunction, as in f.unit() and f.string("...").

Now that we have a thread_local way to track what goes where, these literal constructors would make more sense as plain functions rather than methods of MakeFunction: reflect::unit() and reflect::string("...").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant