Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AST to hold const generics #227

Closed
dtolnay opened this issue Nov 11, 2017 · 2 comments
Closed

Update AST to hold const generics #227

dtolnay opened this issue Nov 11, 2017 · 2 comments
Assignees
@mystor
Labels
syntax
Milestone
0.12

Comments

@dtolnay
Copy link
Owner

dtolnay commented Nov 11, 2017 •
edited
Loading

The Generics struct now needs to hold lifetimes, ty_params, and const_params.

rust-lang/rust#44580

struct RectangularArray<T, const WIDTH: usize, const HEIGHT: usize> {
    array: [[T; WIDTH]; HEIGHT],
}
@dtolnay dtolnay mentioned this issue Nov 11, 2017
Closed
@eddyb
Copy link

eddyb commented Nov 11, 2017

That's not how we're doing it in the compiler, see rust-lang/rust#45930.

@dtolnay dtolnay added the syntax label Nov 13, 2017
@mystor mystor added this to the 0.12 milestone Nov 18, 2017
@mystor mystor mentioned this issue Dec 5, 2017
Merged
@dtolnay
Copy link
Owner Author

dtolnay commented Dec 5, 2017

Implemented in #261.

@dtolnay dtolnay closed this as completed Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mystor mystor

Labels
syntax
Projects
None yet
Milestone
0.12
Development

No branches or pull requests
3 participants
@eddyb @mystor @dtolnay