Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AST to hold extern types #230

Closed
dtolnay opened this issue Nov 11, 2017 · 2 comments
Closed

Update AST to hold extern types #230

dtolnay opened this issue Nov 11, 2017 · 2 comments
Labels

Comments

@dtolnay
Copy link
Owner

dtolnay commented Nov 11, 2017

rust-lang/rust#43467

extern {
    type T;
}
@mystor
Copy link
Collaborator

mystor commented Nov 11, 2017

As part of this, we should probably also update the sha1 of the rust-lang repo which we run tests against if we can. Unfortunately, the syntex hasn't been being kept up to date so it won't support all of the features which we would want to support :-/.

Perhaps we should consider updating the tests to instead build against nightly rust & use libsyntax directly? We'd have to make them run periodically & not fail CI if they don't pass like clippy probably.

@dtolnay
Copy link
Owner Author

dtolnay commented Nov 11, 2017

I agree. I filed #232 to follow up with moving to libsyntax.

This was referenced Nov 11, 2017
@dtolnay dtolnay added the syntax label Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants