Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply #[doc(cfg(feature = "..."))] on docs.rs #731

Closed
dtolnay opened this issue Dec 4, 2019 · 1 comment · Fixed by #925
Closed

Apply #[doc(cfg(feature = "..."))] on docs.rs #731

dtolnay opened this issue Dec 4, 2019 · 1 comment · Fixed by #925

Comments

@dtolnay
Copy link
Owner

dtolnay commented Dec 4, 2019

Like what Tokio does:

https://github.com/tokio-rs/tokio/blob/0e729aa341028c121b9c39fe552ed4309bae6b6a/tokio/src/macros/cfg.rs#L241

https://docs.rs/tokio/0.2.2/tokio/task/fn.block_in_place.html

This turns into a blue cfg banner that is nicer than our current notes about "This type is available if Syn is built with the "full" feature."

doccfg
@jfrimmel jfrimmel mentioned this issue Dec 15, 2019
Closed
@dtolnay
Copy link
Owner Author

dtolnay commented Dec 25, 2019

This is blocked until the doc_cfg feature is in better shape (rust-lang/rust#43781 (comment)).

@dtolnay dtolnay mentioned this issue May 15, 2020
Closed
@a1phyr a1phyr mentioned this issue May 29, 2020
Closed
@dtolnay dtolnay removed the blocked label Nov 21, 2020
@dtolnay dtolnay mentioned this issue Nov 21, 2020
Merged
@dtolnay dtolnay mentioned this issue Nov 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dtolnay