Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow automatic Unit-e daemon download #50

Open
cmihai opened this issue Feb 12, 2019 · 1 comment
Open

Allow automatic Unit-e daemon download #50

cmihai opened this issue Feb 12, 2019 · 1 comment
Assignees
Labels
bug A problem of existing functionality
Milestone

Comments

@cmihai
Copy link
Member

cmihai commented Feb 12, 2019

Describe the bug
The functionality to check the Unit-e GitHub repository for the daemon package and automatically download and unpack it is currently commented out, because there are no public daemon packages yet.
As a result, right now the user has to start the daemon manually before running the wallet. We should uncomment and test the download functionality before the testnet is live.

To Reproduce
Steps to reproduce the behavior:

  1. Launch the unite-desktop Electron wallet
  2. Notice that it's failing to connect to the daemon unless united is already running on the machine.

Expected behavior
The wallet automatically downloads the daemon package, extracts it in a directory under $HOME, and runs it.

@cmihai cmihai added the bug A problem of existing functionality label Feb 12, 2019
@cmihai cmihai added this to the 0.1 milestone Feb 12, 2019
@cmihai cmihai self-assigned this Feb 12, 2019
@cornelius
Copy link
Member

I suppose it's implied in the description but just to make it explicit: There needs to be a check that the downloaded package is a trusted build of the client and nobody has tampered with it or the way how it's downloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A problem of existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants