Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Buy Limit Orders #459

Closed
dib542 opened this issue Oct 2, 2023 · 0 comments · Fixed by #539, #544 or #547
Closed

Improve Buy Limit Orders #459

dib542 opened this issue Oct 2, 2023 · 0 comments · Fixed by #539, #544 or #547

Comments

@dib542
Copy link
Collaborator

dib542 commented Oct 2, 2023

Follows #420

The "amount" field in a Buy Limit Order should be editable, but currently achieving this is difficult

  • this requires a bit of work because we can't calculate the amount in required for an amount out locally
  • we should first use the work of Replace Swap estimation calculation with chain simulation data #408 to get the estimation data of a market limit order that has enough tokenIn amount and attempts to find a maxAmountOut to solve the calculation of the required amount in for a Buy target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant