Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve Orderbook page UI #527

Merged
merged 18 commits into from
Mar 22, 2024
Merged

feat: improve Orderbook page UI #527

merged 18 commits into from
Mar 22, 2024

Conversation

dib542
Copy link
Collaborator

@dib542 dib542 commented Jan 31, 2024 •
edited
Loading

This PR cleans up parts of the Orderbook page UI

  • Orderbook Charts:

    • prevent "out of order data" errors by preventing updates with duplicate old data points
    • prevent "time jump" issues by filling in blank periods of no activity with the close of the last price
    • prevent incorrect indexer data requests from being sent while token denoms are still resolving
    • use dark theme as default color scheme
    • fix timezone displayed on Chart to timezone detected in browser
    • fix issue where if no recent data was found, the chart would cease queries for older data
    • fixed priority and mutation of indexer query params: nextKey page requests should not accept extra new params

  • Orderbook List (close-to-price liquidity buckets table) card:

    • fix the calculation of liquidity bucket amounts when token pair is in inverted order

  • Orderbook Limit Order card:

    • prevent LastPass from trying to fill the numeric "amount" field with saved passwords

@dib542 dib542 marked this pull request as draft January 31, 2024 10:05
@dib542 dib542 force-pushed the 459-improve-buy-limit-orders-part-1 branch from b96b82f to a269159 Compare March 13, 2024 18:36
@dib542 dib542 marked this pull request as ready for review March 13, 2024 19:26
@dib542 dib542 changed the title feat: improve buy/sell Orderbook card feat: improve Orderbook page UI Mar 13, 2024
@dib542 dib542 linked an issue Mar 13, 2024 that may be closed by this pull request
Add Orderbook page and Orderbook UI #420
Closed
@github-actions GitHub Actions
Copy link

Deploy Previews

Testnet

Preview URL: https://de245596-34a4f9a1--duality-xyz-testnet.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/65f1ff6ed301161e3100047d

Beta

Preview URL: https://de245596-34a4f9a1--duality-xyz-beta.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/65f1ffbc0171f31ee692b067

dib542 added a commit that referenced this pull request Mar 14, 2024
@dib542
#527
c1338ed
@dib542 dib542 mentioned this pull request Mar 14, 2024
Closed
@github-actions GitHub Actions
Copy link

Deploy Previews

Testnet

Preview URL: https://266e16f3-4ca9f360--duality-xyz-testnet.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/65f4474cfa83166044ab20a8

Beta

Preview URL: https://266e16f3-4ca9f360--duality-xyz-beta.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/65f4479787a62463bf1aa125

@github-actions GitHub Actions
Copy link

Deploy Previews

Testnet

Preview URL: https://b1d926c6-0abb39e5--duality-xyz-testnet.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/65f44e7187a62469831aa191

Beta

Preview URL: https://b1d926c6-0abb39e5--duality-xyz-beta.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-beta/deploys/65f44ebcfe36e003f37621eb

@dib542 dib542 merged commit 3f5e90a into main Mar 22, 2024
1 check passed
@dib542 dib542 deleted the 459-improve-buy-limit-orders-part-1 branch March 22, 2024 12:09
dib542 pushed a commit that referenced this pull request Mar 22, 2024
@semantic-release-bot
chore(release): 2.3.0 [skip ci]
7b3800d 
## [2.3.0](v2.2.1...v2.3.0) (2024-03-22)

### Features

* improve Orderbook page UI ([#527](#527)) ([3f5e90a](3f5e90a))
@dib542
Copy link
Collaborator Author

dib542 commented Mar 22, 2024

🎉 This PR is included in version 2.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
deploy preview released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Orderbook page and Orderbook UI
1 participant
@dib542