-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Select Input UI should not close before selecting input #550
fix: Select Input UI should not close before selecting input #550
Conversation
Deploy PreviewsTestnetPreview URL: https://256ee9d1-9e898666--duality-xyz-testnet.netlify.app BetaPreview URL: https://256ee9d1-9e898666--duality-xyz-beta.netlify.app |
Using the Tab key to move through select options does not work on Safari (pressing Tab key closes the select option pane) |
…re-selecting-input
…re-selecting-input
Deploy PreviewsTestnetPreview URL: https://1bf75b10-c84759ed--duality-xyz-testnet.netlify.app BetaPreview URL: https://1bf75b10-c84759ed--duality-xyz-beta.netlify.app |
## [2.8.1](v2.8.0...v2.8.1) (2024-05-02) ### Fixes * Select Input UI should not close before selecting input ([#550](#550)) ([a9d8e4f](a9d8e4f))
🎉 This PR is included in version 2.8.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR attempts to improve the selection behavior of the
SelectInput
component.Previously the
SelectInput
component could sometimes close before confirming the selection of a new option. This is very frustrating because when it happens it makes the SelectInput component unusable and the value in the form cannot be changed from the default selection.Now the component no longer relies on a
setTimeout
to close the selection options and instead relies on the completion of specific actions which should always occur after a new option is selected.