Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select Input UI should not close before selecting input #550

Merged

Conversation

dib542
Copy link
Collaborator

@dib542 dib542 commented Apr 25, 2024

This PR attempts to improve the selection behavior of the SelectInput component.

Previously the SelectInput component could sometimes close before confirming the selection of a new option. This is very frustrating because when it happens it makes the SelectInput component unusable and the value in the form cannot be changed from the default selection.

Now the component no longer relies on a setTimeout to close the selection options and instead relies on the completion of specific actions which should always occur after a new option is selected.

@dib542
Copy link
Collaborator Author

dib542 commented Apr 26, 2024

Using the Tab key to move through select options does not work on Safari (pressing Tab key closes the select option pane)

@dib542 dib542 merged commit a9d8e4f into main May 2, 2024
2 checks passed
@dib542 dib542 deleted the 549-fix-selectinput-component-can-close-before-selecting-input branch May 2, 2024 00:39
dib542 pushed a commit that referenced this pull request May 2, 2024
## [2.8.1](v2.8.0...v2.8.1) (2024-05-02)

### Fixes

* Select Input UI should not close before selecting input ([#550](#550)) ([a9d8e4f](a9d8e4f))
@dib542
Copy link
Collaborator Author

dib542 commented May 2, 2024

🎉 This PR is included in version 2.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dib542 dib542 added the released label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: SelectInput component can close before selecting input
2 participants