Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: connect core backend #102

Merged
merged 33 commits into from
Aug 26, 2022
Merged

feat: connect core backend #102

merged 33 commits into from
Aug 26, 2022

Conversation

dib542
Copy link
Collaborator

@dib542 dib542 commented Aug 1, 2022 •
edited
Loading

This PR adds the backend of duality (commit duality-labs/duality@0768dd5) and removes the backend of duality-cosmos-mock.

Changes:

  1. replaces old generated code (src/lib/web3/generated/duality/duality.duality/*) with new generated code (src/lib/web3/generated/duality/nicholasdotsol.duality.*/*)
  2. removes custom src/lib/web3/api.ts work
    • why: incorrect assumption that we would only need one Cosmos module and api.ts would handle all of those
    • fix: a new script scripts/update-generated-files.sh transforms each module's index.ts file to meet the minimum requirements needed to call the autogenerated function correctly. In a way this is a step back, as some options are no longer exposed. Overall it could be considered a step forward: running npm run update no longer requires you to manually update api.ts to reflect other autogenerated changes.
  3. Tick structures no longer have price0/price1 values. This has been replaced with price as a decimal ratio (18 decimal place precision) of price1/price0.
  4. the flat ticks array structure in queries has been replaced with a nested structure: an array of Pair objects each with two arrays of Pool objects: poolsZeroToOne and poolsOneToZero.
    • I have preserved both the poolArray structure (ordered pool arrays to act as sortedTicks for the router) and a ticks TickMap structure to lookup individual ticks for individual tick updates (this could however be removed) as it doesn't yet serve a purpose.
  5. PairIDs are sorted by the backend, the frontend is currently treated as if it cannot know the sorting function and attempts to find sorted pairIDs by guessing in both directions. This could be improved by knowing the sort function which may rely of token attributes other than the token ID string and a small refactor may be necessary passing token objects through functions instead of token strings.
  6. The router module does not accept a swap path by a frontend router, instead it accepts tokenA, tokenB, amountIn, and minOut as parameters and calculates the swap path by itself. Therefore the front-end router is treated as an estimator to calculate a reasonable minOut value to pass to the router.
  7. Adds logic to updated tickState in response to NewDeposit, NewWithdraw, and NewSwap events.

Not implemented:

  • this does not implement the MsgSingleDeposit and MsgSingleWithdraw msg actions.
    • why: the pool page is not yet connected to msg actions.
  • this does not implement improvements that would require changes on the backend
    • eg. a TotalShares attribute could be passed by deposit and withdraw events instead of computing current totalShares values

Fixes:

@dib542 dib542 linked an issue Aug 1, 2022 that may be closed by this pull request
Connect core backend #100
Closed
@dib542 dib542 force-pushed the 100-connect-core-backend branch 3 times, most recently from 6ac3624 to a42af47 Compare August 3, 2022 03:45
@dib542 dib542 requested a review from nickzoum August 3, 2022 05:17
@dib542 dib542 force-pushed the 100-connect-core-backend branch from a42af47 to f3bde6a Compare August 3, 2022 05:20
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Preview URL: https://62ea064ecfcf2656ba29e81c--graceful-palmier-ff28ba.netlify.app
Logs: https://app.netlify.com/sites/graceful-palmier-ff28ba/deploys/62ea064ecfcf2656ba29e81c

dib542 added 13 commits August 4, 2022 04:22
@dib542
Generalise script for reading from production repo
e04feaf
@dib542
Fix autogenerated code files with update script
239cb33
@dib542
Add auto-generated code from production repo
92b7e58
@dib542
Add local dev coins from backend repo
57bde17
@dib542
Swap cosmos mock backend logic with cosmos core logic
84b6b13
@dib542
Fix searching of state for tick pairs: frontend has no sorting context
779aaba
@dib542
Remove cosmos-mock generated (and semi-generated code)
0441b66
@dib542
Add sorted Tick arrays and keyed Ticks by ID structures both:
7c27498 
    - to handle different scenarios better:
    - Keyed Ticks by ID are better for isolated context updates better
    - Sorted arrays allow sorting only once when needed
@dib542
Stop storing TickInfo indexes as they need to be updated on new info
e037fb7 
    - when events come through with updates to certain ticks, indexes of all ticks will need to change
@dib542
Optimise finding state pairs without knowing the sorting order
c2c50b1
@dib542
Subscribe to core backend NewDeposit and NewWithdraw shapes
8041d6f
@dib542
Make event new totalShares calculation more understandable
af473d4
@dib542
Fix Query transformation of tick pools to be transformed independently
bcf2cc5
@dib542 dib542 force-pushed the 100-connect-core-backend branch from f3bde6a to 695fd32 Compare August 3, 2022 18:23
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Preview URL: https://62eabdbd04c95e144fff8fa2--graceful-palmier-ff28ba.netlify.app
Logs: https://app.netlify.com/sites/graceful-palmier-ff28ba/deploys/62eabdbd04c95e144fff8fa2

@dib542 dib542 force-pushed the 100-connect-core-backend branch from 695fd32 to e1df047 Compare August 3, 2022 18:50
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Preview URL: https://62eac417550159005bf6b60f--graceful-palmier-ff28ba.netlify.app
Logs: https://app.netlify.com/sites/graceful-palmier-ff28ba/deploys/62eac417550159005bf6b60f

@dib542
Copy link
Collaborator Author

dib542 commented Aug 3, 2022

I'm thinking maybe we should remove totalShares from the front end tick state completely. I don't think we're ever going to need it, its a value for backend withdrawal calculations only.

dib542
dib542 commented Aug 4, 2022
View reviewed changes
src/lib/web3/indexerProvider.tsx Outdated Show resolved Hide resolved
src/lib/web3/indexerProvider.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

Preview URL: https://62ec2cbfba5a222e033c3822--graceful-palmier-ff28ba.netlify.app
Logs: https://app.netlify.com/sites/graceful-palmier-ff28ba/deploys/62ec2cbfba5a222e033c3822

dib542 added 2 commits August 5, 2022 12:06
@dib542
Do not check for pool length in one direction:
3c914c6 
    - pools may be empty in one direction if there is no liquidity of one of the tokens available
@dib542
Fix tickState sorted pools shape on handling Events
dc8e7e0
@github-actions
Copy link

github-actions bot commented Aug 5, 2022

Preview URL: https://62ec8811488b4a75eda069bc--graceful-palmier-ff28ba.netlify.app
Logs: https://app.netlify.com/sites/graceful-palmier-ff28ba/deploys/62ec8811488b4a75eda069bc

@github-actions
Copy link

github-actions bot commented Aug 5, 2022

Preview URL: https://62eca8ca8b5f9f086d324dbb--graceful-palmier-ff28ba.netlify.app
Logs: https://app.netlify.com/sites/graceful-palmier-ff28ba/deploys/62eca8ca8b5f9f086d324dbb

nickzoum
nickzoum approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@nickzoum nickzoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/lib/web3/indexerProvider.tsx Outdated Show resolved Hide resolved
dib542 added a commit that referenced this pull request Aug 5, 2022
@dib542
#102
69dc8e8
@dib542 dib542 mentioned this pull request Aug 5, 2022
Merged
@github-actions
Copy link

Preview URL: https://6303e1f6a7fa8022da524167--graceful-palmier-ff28ba.netlify.app
Logs: https://app.netlify.com/sites/graceful-palmier-ff28ba/deploys/6303e1f6a7fa8022da524167

@dib542 dib542 merged commit 7ca9e8c into main Aug 26, 2022
@dib542 dib542 deleted the 100-connect-core-backend branch August 26, 2022 00:32
dib542 pushed a commit that referenced this pull request Aug 26, 2022
@semantic-release-bot
chore(release): 0.1.16 [skip ci]
a5599bd 
## [0.1.16](v0.1.15...v0.1.16) (2022-08-26)

### Features

* connect core backend ([#102](#102)) ([7ca9e8c](7ca9e8c))
@dib542
Copy link
Collaborator Author

dib542 commented Aug 26, 2022

🎉 This PR is included in version 0.1.16 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

Preview URL: https://6308158a3f533d16d57b1cf5--graceful-palmier-ff28ba.netlify.app
Logs: https://app.netlify.com/sites/graceful-palmier-ff28ba/deploys/6308158a3f533d16d57b1cf5

@dib542 dib542 mentioned this pull request Dec 6, 2022
Merged
@dib542 dib542 mentioned this pull request Jan 10, 2023
Merged
dib542 added a commit that referenced this pull request Jan 10, 2023
@dib542
Add current version of the backend into the ReadMe file:
fc928c3 
    - This is the current used version since release v0.1.58:
        - https://github.com/duality-labs/duality-web-app/releases/tag/v0.1.58
        - #173

    - before that the FE was developed against an unreleased branch:
        - duality-labs/duality@0768dd5
        - #102

    - and before that the FE was developed against an Ethereum chain
      on a different unreleased prototype repository
dib542 added a commit that referenced this pull request Jan 10, 2023
@dib542
docs: add current version of the backend into the ReadMe file (#276)
1c6e55f 
* Add current version of the backend into the ReadMe file:

    - This is the current used version since release v0.1.58:
        - https://github.com/duality-labs/duality-web-app/releases/tag/v0.1.58
        - #173

    - before that the FE was developed against an unreleased branch:
        - duality-labs/duality@0768dd5
        - #102

    - and before that the FE was developed against an Ethereum chain
      on a different unreleased prototype repository

* Generalize backend version note so it only needs to be updated once
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickzoum nickzoum nickzoum approved these changes

Assignees
No one assigned
Labels
deploy preview released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connect core backend
2 participants
@dib542 @nickzoum