feat: 52 - add theming #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nickzoum
force-pushed
the
52-add-theming
branch
from
7429d12 to
9123078
Compare
nickzoum
force-pushed
the
52-add-theming
branch
from
99ae194 to
c696864
Compare
nickzoum
force-pushed
the
52-add-theming
branch
from
71f7e5f to
6ab34f9
Compare
dib542
reviewed
Aug 3, 2022
dib542
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
Looks good, functional, and most minor issues resolved.
The part around the setting the theme can be improved a bit, for example by using a context so that the computation of the theme state is only done once and can be used anywhere. And it would be great if it could handle theme changes originating from other tabs. But otherwise it's at least understandable how it is working. Any improvements there would be welcome.
toggle theme mode button use provider
nickzoum
force-pushed
the
52-add-theming
branch
from
f0d1880 to
ceca761
Compare
rename getDefaultBrowserTheme
nickzoum
force-pushed
the
52-add-theming
branch
from
bbb0922 to
c837bfb
Compare
dib542
approved these changes
Aug 4, 2022
src/lib/themeProvider.tsx
Outdated
| const themeProperty = '--default-theme'; | ||
|
|
||
| interface ThemeContextType { | ||
| setThemeMode: (theme: ThemeMode | null) => void; |
There was a problem hiding this comment.
since ThemeMode | null gets used many times it could be declared as a SavedThemeMode type.
nickzoum
force-pushed
the
52-add-theming
branch
from
a1c64b6 to
2e34737
Compare
dib542
pushed a commit
that referenced
this pull request
Aug 4, 2022
## [0.1.12](v0.1.11...v0.1.12) (2022-08-04) ### Features * 52 - add theming ([#104](#104)) ([eb86a72](eb86a72))
|
🎉 This PR is included in version 0.1.12 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main 3 css files of this PR contain a list of the sass variables that are affected by the current theme.
The sass properties get converted to css ones by the
props.scssfile.The
useThemeMode.tscan get (+ hook) and save the theme mode.