Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 86 - update liquidity page to read tick state from cosmos #89

Merged
merged 26 commits into from
Jul 26, 2022
Merged

feat: 86 - update liquidity page to read tick state from cosmos #89

merged 26 commits into from
Jul 26, 2022

Conversation

dib542
Copy link
Collaborator

@dib542 dib542 commented Jul 5, 2022 •
edited
Loading

This PR adds the Liquidity page with Cosmos data fetching.

@dib542 dib542 linked an issue Jul 5, 2022 that may be closed by this pull request
Update liquidity page to read tick state from Cosmos #86
Closed
@dib542 dib542 force-pushed the 86-update-liquidity-page-to-read-tick-state-from-cosmos branch from bcc0093 to ff832b2 Compare July 8, 2022 20:57
@dib542 dib542 force-pushed the 86-update-liquidity-page-to-read-tick-state-from-cosmos branch 4 times, most recently from f859174 to 81cc87a Compare July 21, 2022 22:42
@dib542 dib542 requested a review from nickzoum July 21, 2022 22:43
@dib542 dib542 changed the title 86 - update liquidity page to read tick state from cosmos feat: 86 - update liquidity page to read tick state from cosmos Jul 21, 2022
nickzoum
nickzoum approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@nickzoum nickzoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I think some parts (fetching ticks listening to events) might belong to another branch

src/pages/Pool/Pool.tsx Outdated Show resolved Hide resolved
src/pages/Pool/Pool.tsx Outdated Show resolved Hide resolved
src/pages/Pool/Pool.tsx Outdated Show resolved Hide resolved
src/components/TokenPicker/mockHooks.ts Show resolved Hide resolved
@dib542 dib542 mentioned this pull request Jul 22, 2022
Merged
dib542 and others added 20 commits July 26, 2022 09:37
@dib542
Add fetching tick query details with JSON string output
119b262
@dib542
Only fetch ticks when token pair is defined
c62f97c
@dib542
Fix getting data out of ticks error
6d944f1
@dib542
Fix resetting ticks fetch error
f246763
@dib542
Move tick debug output higher for easy visibility
1c36945
@dib542
Fix on cancelled possible issue
414d3b8
@dib542
Improve loading state
a659496
@dib542
Improve printout of tick state
09c5f74
@dib542
Add reading of events in Pool page
d48bbad
@dib542
Make query effect more consistent
369d571
@dib542
Use Tx event listening instead of generic event listening
42e12b0
@dib542
Update ticks state inside Pool page
669396e
@dib542
Update dev token addresses to match those in Cosmos mock
2247378
@dib542
Update subscription calls with new event subscription manager updates
ba54c02
@dib542
Fix Pool page opening websocket race condition issues
0c73aec
@dib542
Try to add a subscriptionManager.open to match .close
5261166
@dib542
Revert "Try to add a subscriptionManager.open to match .close"
8594db0 
This reverts commit 56fb302.
@dib542
Fix onMessage type
d0e3c71
@dib542 @nickzoum
Make onMessage function type easier to read
c483b2f 
Co-authored-by: Nick Z <nzoumis@outlook.com>
@dib542
Use environment variables in Pool page
1d2cbb2
@dib542 dib542 force-pushed the 86-update-liquidity-page-to-read-tick-state-from-cosmos branch from a7c866d to 2e5d4eb Compare July 25, 2022 23:57
nickzoum
nickzoum approved these changes Jul 26, 2022
View reviewed changes
src/pages/Pool/Pool.tsx Outdated Show resolved Hide resolved
nickzoum
nickzoum reviewed Jul 26, 2022
View reviewed changes
src/pages/Pool/Pool.tsx Outdated Show resolved Hide resolved
@dib542 dib542 merged commit 91dcbe9 into main Jul 26, 2022
@dib542 dib542 deleted the 86-update-liquidity-page-to-read-tick-state-from-cosmos branch July 26, 2022 00:15
dib542 pushed a commit that referenced this pull request Jul 26, 2022
@semantic-release-bot
chore(release): 0.1.9 [skip ci]
aef3264 
## [0.1.9](v0.1.8...v0.1.9) (2022-07-26)

### Features

* 86 - update liquidity page to read tick state from cosmos ([#89](#89)) ([91dcbe9](91dcbe9))
@dib542
Copy link
Collaborator Author

dib542 commented Jul 26, 2022

🎉 This PR is included in version 0.1.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickzoum nickzoum nickzoum approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update liquidity page to read tick state from Cosmos
2 participants
@dib542 @nickzoum