Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing the toast message after creating a tag closes the edit modal #1654

Closed
DeepaPrasanna opened this issue Oct 25, 2024 · 5 comments · Fixed by #1725
Closed

Closing the toast message after creating a tag closes the edit modal #1654

DeepaPrasanna opened this issue Oct 25, 2024 · 5 comments · Fixed by #1725

Comments

@DeepaPrasanna
Copy link

I was trying to close the toast after creating the tag while editing the link. I'm not sure if this behavior is expected, but it doesn't seem ideal, as all the changes I made were undone, and I had to edit it again.

As I have exhausted my tags creation limit, I can't show the same message though
https://www.loom.com/share/40eddb7c7e114a12ab2bf3ef6d4b8d8c?sid=76c8bceb-3756-4e34-b4f6-32abada29b91

Copy link

linear bot commented Oct 25, 2024

@unrenamed
Copy link
Contributor

Oddly, swiping it down on mobile does not close the last opened modal 🤔

@steven-tey
Copy link
Collaborator

/award 150 yeah this looks like a bug

Copy link

oss-gg bot commented Oct 27, 2024

Awarding DeepaPrasanna: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/DeepaPrasanna

@unrenamed
Copy link
Contributor

unrenamed commented Nov 16, 2024

@steven-tey, there’s a potential fix for Radix UI Dialog components (see link), but adapting it for Vaul's Drawer is challenging — for some modal the solution works, for others doesn't (it may be related to the way modals and nested modals are rendered).
Turns out, not all dialog windows are true "modals"—some are just popover wannabes! So, I just had to sprinkle that fix across all components using the Vaul Drawer.

I could submit a PR for the Radix Dialog fix if you want, but a solution for Vaul’s Drawer may need input from its authors. There’s a similar open issue in their repo, though the suggested fix doesn’t fully address it.
I’ve gone ahead and submitted a PR with a fix for both the Radix Dialog and Vaul Drawer components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants