Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delta_scan pre-pends table path which will break shallow-cloned tables #74

Open
zachschuermann opened this issue Aug 22, 2024 · 1 comment
Open

delta_scan pre-pends table path which will break shallow-cloned tables #74

zachschuermann opened this issue Aug 22, 2024 · 1 comment

Comments

@zachschuermann
Copy link

blindly prepending the table path won't allow reads from shallow clones

https://github.com/duckdb/duckdb_delta/blob/main/src/functions/delta_scan.cpp#L50-L52

auto path_string =  context->GetPath();
StringUtil::RTrim(path_string, "/");
path_string += "/" + KernelUtils::FromDeltaString(path);
@zachschuermann
Copy link
Author

cc @scovich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zachschuermann