Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valgrind testing #218

Open
JelteF opened this issue Sep 24, 2024 · 1 comment
Open

Valgrind testing #218

JelteF opened this issue Sep 24, 2024 · 1 comment
Labels
testing Improves testing and/or CI
Milestone
0.1.0 stability t...

Comments

@JelteF
Copy link
Collaborator

JelteF commented Sep 24, 2024

Postgres has some built in valgrind support (which makes valgrind know about palloc and some more things). You have to set -DUSE_VALGRIND in CFLAGS (and I guess maybe CXXFLAGS) when runinng ./configure.

This would be very useful to do this to find issues like #213 more easily.
@Tishj
Copy link
Collaborator

Tishj commented Sep 25, 2024 •
edited
Loading

#213 was an allocation made with just malloc (wrapped by duckdb_malloc but under the hood that's just malloc)
Never the less still good to add this for sure 👍

@JelteF JelteF added this to the 0.1.0 stability testing milestone Sep 30, 2024
@JelteF JelteF added the testing Improves testing and/or CI label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Improves testing and/or CI
Projects
None yet
Milestone
0.1.0 stability testing
Development

No branches or pull requests
2 participants
@JelteF @Tishj