Fix sync connect flow (#1195)

Task/Issue URL: https://app.asana.com/0/0/1204398270301335/f
Tech Design URL:
CC:

**Description**:

Fixes the connect flow.  No BSK changes.

**Steps to test this PR**:
1. On iOS (or "another" device) turn off sync, then turn on sync, choose
sync another device and have it show a code
2. On macOS turn off sync, then turn on sync, choose sync another device
and paste in the connect code from the other device
3. The UI will close and the other device will connect. Eventually the
new device will appear in the UI.
4. Smoke test sync

<!--
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be
marked with the `DO NOT MERGE` label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the `Pending Product
Review` label.

If at any point it isn't actively being worked on/ready for
review/otherwise moving forward (besides the above PR/PFR exception)
strongly consider closing it (or not opening it in the first place). If
you decide not to close it, make sure it's labelled to make it clear the
PRs state and comment with more information.
-->

---
###### Internal references:
[Pull Request Review
Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f)
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
[Pull Request
Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)

Author: brindy

DuckDuckGo/Preferences/Model/SyncPreferences.swift

@@ -73,6 +73,15 @@ final class SyncPreferences: ObservableObject, SyncUI.ManagementViewModel {
     @MainActor
     func presentShowOrEnterCodeDialog() {
         Task { @MainActor in
+            let devicesAtStart = self.devices
+            self.$devices
+                .removeDuplicates()
+                .dropFirst()
+                .prefix(1)
+                .sink { [weak self] _ in
+                    self?.managementDialogModel.endFlow()
+                    self?.objectWillChange.send()
+                }.store(in: &cancellables)
             managementDialogModel.codeToDisplay = syncService.account?.recoveryCode
             presentDialog(for: .syncAnotherDevice)
         }
@@ -152,7 +161,6 @@ final class SyncPreferences: ObservableObject, SyncUI.ManagementViewModel {
                 do {
                     let registeredDevices = try await syncService.fetchDevices()
                     mapDevices(registeredDevices)
-                    print("devices", self.devices)
                 } catch {
                     print("error", error.localizedDescription)
                 }
@@ -207,7 +215,11 @@ extension SyncPreferences: ManagementDialogModelDelegate {
     func deleteAccount() {
         Task { @MainActor in
             managementDialogModel.endFlow()
-            try await syncService.deleteAccount()
+            do {
+                try await syncService.deleteAccount()
+            } catch {
+                managementDialogModel.errorMessage = String(describing: error)
+            }
         }
     }
 
@@ -268,8 +280,21 @@ extension SyncPreferences: ManagementDialogModelDelegate {
                     try await login(recoveryKey)
                     presentDialog(for: .deviceSynced)
                 } else if let connectKey = syncCode.connect {
-                    // Unclear what the UX is supposed to be here given everything is happening on the other device
+                    var isNewAccount = false
+                    if syncService.account == nil {
+                        let device = deviceInfo()
+                        try await syncService.createAccount(deviceName: device.name, deviceType: device.type)
+                        isNewAccount = true
+                    }
+
                     try await syncService.transmitRecoveryKey(connectKey)
+
+                    if isNewAccount {
+                        presentDialog(for: .deviceSynced)
+                    } else {
+                        managementDialogModel.endFlow()
+                    }
+
                 } else {
                     managementDialogModel.errorMessage = "Invalid code"
                     return
@@ -327,7 +352,11 @@ extension SyncPreferences: ManagementDialogModelDelegate {
             guard response == .OK,
                   let location = panel.url else { return }
 
-            try data.writeFileWithProgress(to: location)
+            do {
+                try data.writeFileWithProgress(to: location)
+            } catch {
+                managementDialogModel.errorMessage = String(describing: error)
+            }
         }
 
     }