Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Can we improve our dev workflow? #415

Open
duesee opened this issue Jan 10, 2024 · 0 comments
Open

build: Can we improve our dev workflow? #415

duesee opened this issue Jan 10, 2024 · 0 comments
Labels
community Improvement to onboarding and collaboration help wanted Extra attention is needed question Further information is requested

Comments

@duesee
Copy link
Owner

duesee commented Jan 10, 2024

We have a workspace with imap-codec depending on imap-types and we (currently) develop both in lockstep. Thus, we use a [patch] directive to tell Cargo to use the local imap-types. All other crates ...

$ find **/Cargo.toml
assets/demos/tokio-client/Cargo.toml
assets/demos/tokio-server/Cargo.toml
assets/demos/tokio-support/Cargo.toml
Cargo.toml
imap-codec/Cargo.toml
imap-codec/fuzz/Cargo.toml
imap-types/Cargo.toml
imap-types/fuzz/Cargo.toml

... use path = "imap-{types,codec}" directly.

Thoughts/Observations:

  • I want cargo-semver-checks to check for breaking changes. Updating imap-types (whose types we expose in the public API of imap-codec) is a breaking change, too. Thus, cargo-semver-checks should check. But it also needs to ignore the local [patch] because otherwise we would check local vs local. So... it tries to fetch imap-types 2.0.0 from crates.io and fails. (Possibly a mistake in thinking here ...)
  • When we do a release, we need to make sure to first publish imap-types and then imap-codec (depending on imap-types on crates.io.) Question: Are there any checks we might miss doing so?
  • ...
@duesee duesee added help wanted Extra attention is needed question Further information is requested community Improvement to onboarding and collaboration labels Jan 10, 2024
@duesee duesee changed the title build: Figure out a better dev workflow build: Can we improve our dev workflow? Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Improvement to onboarding and collaboration help wanted Extra attention is needed question Further information is requested
Projects
Status: No status
Development

No branches or pull requests

1 participant