Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some problem with lazy loaded controllers #8

Open
amakuningit opened this issue Mar 21, 2016 · 5 comments
Open

Some problem with lazy loaded controllers #8

amakuningit opened this issue Mar 21, 2016 · 5 comments

Comments

@amakuningit
Copy link

In 'dummy' app, added into controllers/about.js:
actions : { testAction : function () { console.log('test'); } }, someProp : true });
templates/about.hbs:
<h3 {{action 'testAction' on 'click'}}>About page </h3>
Got in console:
ember.debug.js:16628 Uncaught Error: Nothing handled the action 'testAction'

@duizendnegen
Copy link
Owner

Thanks, will fix soon, also welcoming a PR

@Cryrivers
Copy link

is it possibly because lazy-loaded modules are not registered in the registry?

@duizendnegen
Copy link
Owner

This is possible - the happy path is surely to switch away from this plugin and use ember-engines, their beta version is more stable than this addon & also supports lazy loading.

@Cryrivers
Copy link

@duizendnegen yeah, but only services and routes can be shared in ember-engines, i believe people will still choose ember-cli-lazy-load to build lazy bundles in most cases.

@duizendnegen
Copy link
Owner

I'd happily accept a PR which fixes entering lady-loaded modules in the registry. I did not spend any effort on making sure that happens so it's very much possible that the registry entry doesn't happen.

If there is an open or closed issue on ember-engines highlighting the decision to not support anything but routes and services, I'd be very happy if you could link it in here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants