Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Import package issue on v0.2.2 #68

Closed
MartinGbz opened this issue Sep 19, 2024 · 6 comments · Fixed by #69
Closed

🐛 Import package issue on v0.2.2 #68

MartinGbz opened this issue Sep 19, 2024 · 6 comments · Fixed by #69

Comments

@MartinGbz
Copy link

It seems since the version 0.2.2 (published a few hours ago from this post) the package is not recognized anymore in JS/TS projects.

I haven't dug into it yet, but I've just tried importing it into 2 different repo and I got the same issue:

  • code: import { DuneClient } from "@duneanalytics/client-sdk";
    ⬇️
  • error: Cannot find module '@duneanalytics/client-sdk' or its corresponding type declarations.

Before v0.2.2 I didn't have any issue with the package.

@bh2smith
Copy link
Collaborator

Right sorry. I forgot to update the location of the files in the dist directory. Sorry will fix very soon.

@bh2smith
Copy link
Collaborator

bh2smith commented Sep 19, 2024

Fixed in https://github.com/duneanalytics/ts-dune-client/releases/tag/v0.2.3 by #69

Thanks for reporting and sorry for the hassle.

Let me know if you have any further issues here @MartinGbz - as I have not yet tried it.

@bh2smith
Copy link
Collaborator

Ok there is still an issue here because we import package.json to read the package version. Will need to make one more change.

@bh2smith bh2smith reopened this Sep 20, 2024
@bh2smith
Copy link
Collaborator

Very sorry - this should do the trick

https://github.com/duneanalytics/ts-dune-client/releases/tag/v0.2.4

@bh2smith
Copy link
Collaborator

Tested here:

bh2smith/demo-ts-dune-client#8

@MartinGbz
Copy link
Author

I confirm it works now, thanks for your reactivity sir! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants