Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solarizedl — matching parentheses are (almost) invisible #311

Open
boffi opened this issue Dec 6, 2018 · 1 comment · May be fixed by #446
Open

solarizedl — matching parentheses are (almost) invisible #311

boffi opened this issue Dec 6, 2018 · 1 comment · May be fixed by #446

Comments

@boffi
Copy link

boffi commented Dec 6, 2018 •
edited
Loading

The theme solarizedl has a small misfeature, namely the foreground color used for matching parentheses, used when the cursor lies in the vicinity of one of them, is nearly indistinguishable from the default background. Please see the following scaled screenshot

image

taken from a 250% scaled browser window and further magnified by xmag — I say this because at normal scaling, with the help of anti-aliasing, the invisible-ness is much more severe...

I have had a look to solarizedl.css and it seems that the culprit is

div.CodeMirror span.CodeMirror-matchingbracket {
 color: #ffffff;
 font-weight: bold;
 background-color: #fdf6e3;
}

but I cannot tell where in solarized.less the clause above is generated, so I cannot propose a patch.

PS wrt matching parentheses, I checked all the other themes and they are OK, the matching parentheses are always correctly highlighted.
mikeyk added a commit to mikeyk/jupyter-themes that referenced this issue May 3, 2019
@mikeyk
Fix Solarized Light inverse Color
c649e37 
Fixes Issue dunovank#311, where the matching parentheses in Solarized Light are set to white rather than a contrasting color. I followed the lead of the Solarized Dark theme (theme flavor is black, inverse is white) but reversed.
@mikeyk mikeyk mentioned this issue May 3, 2019
Closed
@xzymustbexzy
Copy link

@boffi
I meet the same problem and I solve it through modifying css file in ~/.jupyter/custom/custom.css directly.
Firstly, type

vim ~/.jupyter/custom/custom.css

then find

div.CodeMirror span.CodeMirror-matchingbracket   
{  
    color: #INSERT-YOUR-DESIRED-BRACKET-COLOUR-HERE ;  
    background-color: #INSERT-YOUR-DESIRED-BRACKET-BACKGROUND-COLOUR-HERE ;  
}

You may type /matchingbracket to find this block quickly.
Then you can change color. For example,

div.CodeMirror span.CodeMirror-matchingbracket {
 color: #ffffff;
 font-weight: bold;
 background-color: #d13f2a;
}

Restart the jupyter, you will see the difference.

image

@PeterMinin PeterMinin linked a pull request Apr 17, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix brackets highlighting in "solarizedl" PeterMinin/jupyter-themes
2 participants
@boffi @xzymustbexzy