Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding solarized-light theme #65

Closed
sv3ndk opened this issue Oct 13, 2016 · 7 comments
Closed

Adding solarized-light theme #65

sv3ndk opened this issue Oct 13, 2016 · 7 comments

Comments

@sv3ndk
Copy link
Contributor

sv3ndk commented Oct 13, 2016

Hi,

Thanks for developing jupyter-themes, that's a very nice little tool!

I forked your repo and started working on a port of the Solarized-light theme of Ethan Schoonover.

Would you welcome a PR from me contributing this theme to your project (if yes, I'll also contact Ethan Schoonover to see how he feels about that)?

I'm not completely finished yet but the current result looks pretty good already, IMHO:

image

image

image

Please let me know what you think

@dunovank
Copy link
Owner

Thanks, and looks great! Totally welcome a pull request whenever you're ready. If I'm slow to accept it's because I'm busy screaming at my dissertation. Will try my best to act in a timely fashion....

Thanks for getting in touch, looking forward to have more outside contributions!

@sv3ndk
Copy link
Contributor Author

sv3ndk commented Oct 24, 2016

Thanks for the encouragements @dunovank .
I understand you're super busy with your dissertation. When do you think you'll find some time to have a look at this PR ? It's super short and quickly validated (I think), and I see this as a first step for the solarized theme.
Thanks!

@carlthome
Copy link

Looks great!

@dunovank
Copy link
Owner

@svendx4f just merged your PR for applying theme to auto-complete menu ( #69 ) .

@xiaohk
Copy link

xiaohk commented Dec 20, 2016

This theme looks pretty good!

@sv3ndk
Copy link
Contributor Author

sv3ndk commented Dec 20, 2016

Thanks for the merge @dunovank, I hope the defence of your dissertation went well?
I continued working on the solarized theme in the meanwhile, see the PR above, I think it's less dark and easier to read than in my original screenshots. I hope you guys like it :)

@dunovank
Copy link
Owner

dunovank commented Jan 6, 2017

Hey @svendx4f , thanks for all the work on that PR. I just confirmed the merge, will be included in the next release (available soon). And yes, dissertation defense went great, enjoying the post-doc life now ;)

Thanks again!

@dunovank dunovank closed this as completed Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants