Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cargo feature for diagnostics #94

Closed
herr-seppia opened this issue Jan 7, 2022 · 0 comments · Fixed by #130
Closed

Add cargo feature for diagnostics #94

herr-seppia opened this issue Jan 7, 2022 · 0 comments · Fixed by #130
Assignees
@HDauven
Labels
status:minor Low priority improvements type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)

Comments

@herr-seppia
Copy link
Member

herr-seppia commented Jan 7, 2022 •
edited
Loading

Describe what you want implemented
Use DiagnosticRwLock only if a specific cargo feature is enabled

Describe "Why" this is needed
Even if the DiagnosticRwLock overhead is almost insignificant, this should not be used always
@herr-seppia herr-seppia added status:minor Low priority improvements type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc) labels Jan 7, 2022
@HDauven HDauven self-assigned this Oct 14, 2023
@HDauven HDauven mentioned this issue Oct 14, 2023
Merged
@ureeves ureeves mentioned this issue Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HDauven HDauven

Labels
status:minor Low priority improvements type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add diagnostics feature flag to RwLock dusk-network/kadcast
2 participants
@HDauven @herr-seppia